Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transaction ID shown to the user #193

Open
vadaynujra opened this issue Oct 4, 2024 · 10 comments
Open

Update transaction ID shown to the user #193

vadaynujra opened this issue Oct 4, 2024 · 10 comments

Comments

@vadaynujra
Copy link

vadaynujra commented Oct 4, 2024

Context

The current transaction ID is a SEP24 generated ID and isn't captured in the storage file.

User Story

As a developer, I want to easily identify and debug transactions in the dump file when users share the transaction ID they receive for unsuccessful transactions.

Requirement

  • Instead of displaying the SEP24 id, show the squidRouterReceiverId instead
    • however, don't show the complete id, but only the first 12 hexadecimal digits in the form dddd-dddd-dddd (where d is one digit)
@TorstenStueber
Copy link
Member

@vadaynujra I updated the description. We already store the complete id in the sheet so there is no work required for additional data dumping.

@prayagd
Copy link
Collaborator

prayagd commented Oct 7, 2024

@prayagd
Copy link
Collaborator

prayagd commented Oct 7, 2024

Remove it from success page and keep it on unsuccess page

@prayagd
Copy link
Collaborator

prayagd commented Oct 11, 2024

@vadaynujra as discussed the squidRouterReceiverId is of no use to the end user, we would need to define what exactly to be shown here

@TorstenStueber i saw after the bridge(polygon to moonbeam) is completed there is txn hash printed in the console but didnt find that hash in the dumping sheet. IMO showing that hash to the end user would be somewhat helpful

@ebma
Copy link
Member

ebma commented Oct 14, 2024

the squidRouterReceiverId is of no use to the end user, we would need to define what exactly to be shown here

Maybe we should discuss this again and with more context. What exactly is the need for this change? Why would we want to show a different ID to the user? Is it a) to be able to assist with debugging if the user approaches us and tells us the exact ID shown to them on the error page or b) the user is able to investigate the issue by themselves? I understood it's about a) and thus, showing the squidRouterReceiverId would be fine as it helps us internally.

@TorstenStueber
Copy link
Member

Yes, I totally agree with @ebma, that is also my understanding. We also don't link to explorers that show any of the many other transactions, so why do it for this very first step of the flow?

@ebma
Copy link
Member

ebma commented Nov 5, 2024

@pendulum-chain/product we did not find an agreement here. Please elaborate on what this identifier is for so we can judge whether it's really needed or how it should look to achieve what you want to gain from it.

@vadaynujra
Copy link
Author

vadaynujra commented Nov 6, 2024

I consider this a Developer user story, to improve / simplify debugging internally. Based on that let's go with the suggestion of squidrouterreceiverID which I see is already updated in the description. Added the user story.

@vadaynujra
Copy link
Author

@ebma with the above solution suggestion, how would we debug transactions where the user is sent to the unsuccessful screen without signing both transactions?

@TorstenStueber
Copy link
Member

We create this id already at the moment the user starts the anchor flow. Failures can't happen before anyway. This means that we will always have the id available whenever the failure screen is shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants