Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compare quote section #247

Open
wants to merge 18 commits into
base: polygon-prototype-staging
Choose a base branch
from

Conversation

ebma
Copy link
Member

@ebma ebma commented Oct 31, 2024

  • Adds a new route quotes to the signer service. Can be called e.g. as follows {endpoint}/v1/quotes?provider=moonpay&fromCrypto=USDC&toFiat=EUR&amount=100. Supported providers are alchemypay ,moonpay, and transak
    Note: while it's possible to combine the provider queries into one e.g. by allowing a parameter providers={}, I decided to keep them separate as this allows showing the results earlier in the frontend instead of having to wait for the response of all three of them on the server.
  • Creates a table for comparing the quotes of the different providers and shows them below the swap form

All three providers provide prices for EUR. Moonpay does not offer prices for offramping ARS while the others do.

The endpoints used are documented here:

We need to add 4 new secrets to the signer service. The following env variables need to be provided:

  • ALCHEMYPAY_APP_ID
  • ALCHEMYPAY_SECRET_KEY
  • TRANSAK_API_KEY
  • MOONPAY_API_KEY

I added all of them to the configuration of the signer-service in our infrastructure already.

I also changed the rateLimitWindowMinutes parameter to just 1 minute. During my testing I hit the limit quite easily so it might be better to be more forgiving with those parameters.

Closes #203.

@ebma ebma linked an issue Oct 31, 2024 that may be closed by this pull request
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for pendulum-pay ready!

Name Link
🔨 Latest commit 1c02e41
🔍 Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/672e14a12f9f0200087ce3db
😎 Deploy Preview https://deploy-preview-247--pendulum-pay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ebma ebma changed the title [Blocked] Add compare quote section Add compare quote section Nov 8, 2024
@ebma ebma requested a review from a team November 8, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add compare quote section
1 participant