-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compare quote section #247
Open
ebma
wants to merge
18
commits into
polygon-prototype-staging
Choose a base branch
from
203-add-compare-quote-section
base: polygon-prototype-staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+792
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quotes
to the signer service. Can be called e.g. as follows{endpoint}/v1/quotes?provider=moonpay&fromCrypto=USDC&toFiat=EUR&amount=100
. Supported providers arealchemypay
,moonpay
, andtransak
Note: while it's possible to combine the provider queries into one e.g. by allowing a parameter
providers={}
, I decided to keep them separate as this allows showing the results earlier in the frontend instead of having to wait for the response of all three of them on the server.All three providers provide prices for EUR. Moonpay does not offer prices for offramping ARS while the others do.
The endpoints used are documented here:
We need to add 4 new secrets to the signer service. The following env variables need to be provided:
ALCHEMYPAY_APP_ID
ALCHEMYPAY_SECRET_KEY
TRANSAK_API_KEY
MOONPAY_API_KEY
I added all of them to the configuration of the signer-service in our infrastructure already.
I also changed the
rateLimitWindowMinutes
parameter to just1
minute. During my testing I hit the limit quite easily so it might be better to be more forgiving with those parameters.Closes #203.