You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The extension and frontend code should be making use of the DenomMetadata at all times. For instance, the assets list makes use of an AssetBalance, which has an ad-hoc subset of different parts of the DenomMetadata, plus an amount. But we already have a way to represent a typed amount (Value) and a way to attach metadata to that typed amount (ValueView).
Values should be rendered using standardized components that take a ValueView, rather than having custom rendering in different places (similarly to how we have a standardized AddressView component)
Values should use the ticker symbols defined in the DenomMetadata.
Do a search for fromBaseUnitAmount. Should find a view examples of where ValueView should replace.
DenomMetadata
at all times. For instance, the assets list makes use of anAssetBalance
, which has an ad-hoc subset of different parts of theDenomMetadata
, plus an amount. But we already have a way to represent a typed amount (Value
) and a way to attach metadata to that typed amount (ValueView
).Value
s should be rendered using standardized components that take aValueView
, rather than having custom rendering in different places (similarly to how we have a standardizedAddressView
component)DenomMetadata
.fromBaseUnitAmount
. Should find a view examples of where ValueView should replace.DenomMetadataByIdRequest
#429Will affect things downstream (swap/send/ibc). Ensure those are not formatting their own values but using
ValueView
.The text was updated successfully, but these errors were encountered: