Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Node Name on add remote service via pmm-admin without metrics scrape #3347

Open
1 task done
mocart2 opened this issue Nov 29, 2024 · 0 comments
Open
1 task done
Assignees
Labels
bug Bug report

Comments

@mocart2
Copy link

mocart2 commented Nov 29, 2024

Description

When I'm add remote mysql(example) service via pmm-admin cli on pmm-server, I get in web-interface inventory Node-name pmm-server everytime, but when I add via web-interface - everything is ok, node-name is sets normally . The nodes are added by cli not monitored, PMM-server can't get metrics from them.

Expected Results

Will be good, for add flag like --nodename=node1.example.com (not exists now)

Actual Results

When I'm add remote mysql(example) service via pmm-admin cli, I get in web-interface inventory Node-name pmm-server every time, but when I add via web-interface- everything is ok, node-name is sets normally

Version

pmm-admin --version
ProjectName: pmm-admin
Version: 2.43.2
PMMVersion: 2.43.2
Timestamp: 2024-10-25 10:28:44 (UTC)
FullCommit: 0c718e65a30c8fd5fbc837a599282e70e8806a53

Steps to reproduce

  1. Execute command inside pmm-server docker container:
pmm-admin add mysql --service-name=node1.example.com --host=node1.example.com --query-source=perfschema --port=3306 --username=mysql_admin --password=mysql_password --server-url=http://admin:[email protected] --server-insecure-tls --environment=stg --cluster=mysql

MySQL Service added.
Service ID  : /service_id/a42076c0-9132-464d-a748-2514b3551ef5
Service name: node1.example.com

Table statistics collection enabled (the limit is 1000, the actual table count is unknown).
  1. Go to web-ui -> Settings -> Inventory and can see 2 nodes with node-name pmm-server:
    image

  2. After try to add via web-ui: web-ui -> Settings -> Inventory -> Add service -> Mysql
    Fill fileds:

  3. Service name: node2.example.com

  4. Hostname: node2.example.com

  5. login

  6. password

  7. Then press button "Add service"
    Service is added normally:
    image

Relevant logs

No response

Code of Conduct

  • I agree to follow Percona Community Code of Conduct
@mocart2 mocart2 added the bug Bug report label Nov 29, 2024
@mocart2 mocart2 changed the title Fixed Node Name on add remote service via pmm-admin with out metrics scrape Fixed Node Name on add remote service via pmm-admin without metrics scrape Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

2 participants