Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coordination number flag. #5

Open
frozzare opened this issue Jun 4, 2019 · 6 comments
Open

Add coordination number flag. #5

frozzare opened this issue Jun 4, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@frozzare
Copy link
Member

frozzare commented Jun 4, 2019

We need a flag on the ::Valid method making it possible to turn of validation for coordination number (+60 on day). The flag should default to enabling them as that is how it is currently working.

See personnummer/meta#9 for meta discussion.

@frozzare frozzare added enhancement New feature or request good first issue Good for newcomers labels Jun 4, 2019
@GoranLilja GoranLilja self-assigned this Nov 14, 2019
@arbitur
Copy link
Contributor

arbitur commented Nov 18, 2019

Just out of curiosity, why would someone want to disable "samordningsnummer"?

@frozzare
Copy link
Member Author

@arbitur not sure why.. personnummer/python#5

@arbitur
Copy link
Contributor

arbitur commented Nov 19, 2019

That issue was created by someone not aware of what samordningsnummer is, I'd say it worked as intended for him. I vote against adding this flag.

@frozzare
Copy link
Member Author

frozzare commented Nov 19, 2019

Maybe, but it may be case where you want to disable this and we have a spec to follow for all implementations (see meta repo). It's not a big thing.

@arbitur
Copy link
Contributor

arbitur commented Nov 19, 2019

Oh, I wasn't aware of the meta repo. I guess it's already settled then 👍

@arbitur
Copy link
Contributor

arbitur commented Nov 19, 2019

I see now that I complettely missed you linked to meta.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants