Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minimalcss takes into account css from iframe #206

Open
stereobooster opened this issue May 23, 2018 · 3 comments · May be fixed by #331
Open

minimalcss takes into account css from iframe #206

stereobooster opened this issue May 23, 2018 · 3 comments · May be fixed by #331
Labels
bug

Comments

@stereobooster
Copy link
Collaborator

Need to investigate. Example https://minimalcss.app/?url=https%3A%2F%2Fstereobooster.github.io%2F
@peterbe
Copy link
Owner

peterbe commented Sep 19, 2019

Another use case:
Screen Shot 2019-09-19 at 3 57 04 PM

@peterbe
Copy link
Owner

peterbe commented Sep 19, 2019

Uhh??

▶ node --trace-warnings ./bin/minimalcss.js https://helloeave.com/

(Have I completely forgotten how to use this thing?!)

@peterbe
Copy link
Owner

peterbe commented Sep 19, 2019

Oh! It's an empty string because that website uses CSS Modules so there's 0 waste. I think the bug lies with minimalcss-server if anything.

peterbe added a commit that referenced this issue Sep 19, 2019
@peterbe
minimalcss takes into account css from iframe
2b74c02 
Fixes #206
@peterbe peterbe linked a pull request Sep 19, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

minimalcss takes into account css from iframe peterbe/minimalcss
2 participants
@peterbe @stereobooster