Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong use of classmethod decorator #106

Open
cayetanobv opened this issue Dec 16, 2018 · 5 comments
Open

Wrong use of classmethod decorator #106

cayetanobv opened this issue Dec 16, 2018 · 5 comments

Comments

@cayetanobv
Copy link
Member

cayetanobv commented Dec 16, 2018

There is a generalized wrong use of classmethod decorator in plugin. In a lot of cases classmethod decorator must be changed by staticmethod decorator. In other cases methods are simply instance methods (no decorator is needed at all).

I've counted 68 use cases to review.

Related docs:

@cvvergara cvvergara added this to the Release 3.0.0 milestone Mar 6, 2019
@cvvergara
Copy link
Member

@cayetanobv This needs review before making the final tag

@cayetanobv
Copy link
Member Author

We can live with this issue for now. I can't do this week or the next. I think we can release final version without this.

@cvvergara
Copy link
Member

changing milestone then

@cayetanobv cayetanobv removed this from the Release 3.0.0 milestone Mar 7, 2019
@cayetanobv
Copy link
Member Author

Removed milestone for this issue. When we release version we add to new milestone created.

@cvvergara cvvergara added this to the Release 3.1.0 milestone Mar 7, 2019
@cvvergara
Copy link
Member

Moved to a next milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants