Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add ctid and other functions to pg_proc #1589

Open
kaspermarstal opened this issue Feb 27, 2024 · 3 comments
Open

Feature request: Add ctid and other functions to pg_proc #1589

kaspermarstal opened this issue Feb 27, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@kaspermarstal
Copy link

Hi,

PL/Rust's pgproc has additional methods that are obviously useful for procedural language extensions like PL/Rust:

Is it possible to add these functions to pgrx's pgrx/src/pg_catalog/pg_proc.rs so they can be used by other procedural language extensions based on pgrx? I imagine this could be useful for PL/Rust as well by avoiding duplicating code. (But perhaps there good reasons that I am unaware of).

@eeeebbbbrrrr
Copy link
Contributor

Ultimately, yeah, it'd be nice to port some version of PL/Rust's PgProc type over to pgrx-proper. There's quite some work happening here right now to shore up pgrx' handling of lifetimes and memory contexts and such. So it'd be hard to guess how much of PL/Rust's existing code would survive v/s needing lots of changes.

That said, we'll at least keep this issue open as a reminder to look at this soon as we can. The pg_proc catalog isn't the only one that would benefit from having a nice wrapper around it. But maybe it can serve as a reference impl to help drive more community contributions around the others.

@workingjubilee
Copy link
Member

Is #1545 what you're looking for?

@workingjubilee workingjubilee added the enhancement New feature or request label Feb 29, 2024
@kaspermarstal
Copy link
Author

Thanks for the hint. But as I understand #1545, this also does not expose e.g. ctid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants