diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 45bac851..e4d47349 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,14 +1,6 @@ -Thank you for your Pull Request! We have developed this task checklist from the -[Development Process -Guide](https://pharmaverse.github.io/admiral/CONTRIBUTING.html#detailed-development-process) -to help with the final steps of the process. Completing the below tasks helps to -ensure our reviewers can maximize their time on your code as well as making sure -the admiral codebase remains robust and consistent. +Thank you for your Pull Request! We have developed this task checklist from the [Development Process Guide](https://pharmaverse.github.io/admiral/CONTRIBUTING.html#detailed-development-process) to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent. -Please check off each taskbox as an acknowledgment that you completed the task -or check off that it is not relevant to your Pull Request. This checklist is -part of the Github Action workflows and the Pull Request will not be merged into -the `main` branch until you have checked off each task. +Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the `main` branch until you have checked off each task. - [ ] Place Closes # into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update). Then the issue is closed automatically once it is merged to `main`. - [ ] Code is formatted according to the [tidyverse style guide](https://style.tidyverse.org/). Run `styler::style_file()` to style R and Rmd files diff --git a/NEWS.md b/NEWS.md index 4e4ec105..4228de27 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,12 @@ # admiralonco (development version) +## Updates of Existing Functions + +- The `bor_ne` event object was updated such that `CR` and `PR` are additionally +considered as event. This ensures that the confirmed best overall response for a +patient with a single `CR` or `PR` assessment is derived as `"NE"` instead of +`"MISSING"`. (#253) + ## Documentation - New vignette "Creating ADRS with iRECIST endpoints". (#233) diff --git a/R/response_sources.R b/R/response_sources.R index c79ed56e..f2fc4c9b 100644 --- a/R/response_sources.R +++ b/R/response_sources.R @@ -136,11 +136,11 @@ bor_pd <- event( #' @export bor_ne <- event( description = paste( - "Define not evaluable (NE) for best overall response (BOR) as SD, NON-CR/NON-PD,", - "or NE (should be specified after bor_sd and bor_non_crpd)" + "Define not evaluable (NE) for best overall response (BOR) as CR, PR, SD,", + "NON-CR/NON-PD, or NE (should be specified after bor_sd and bor_non_crpd)" ), dataset_name = "ovr", - condition = AVALC %in% c("SD", "NON-CR/NON-PD", "NE"), + condition = AVALC %in% c("CR", "PR", "SD", "NON-CR/NON-PD", "NE"), set_values_to = exprs(AVALC = "NE") ) diff --git a/vignettes/irecist.Rmd b/vignettes/irecist.Rmd index 75a3a92e..f3d7812f 100644 --- a/vignettes/irecist.Rmd +++ b/vignettes/irecist.Rmd @@ -648,11 +648,11 @@ ibor_iupd <- event( ibor_ne <- event( description = paste( - "Define not evaluable (NE) for best overall response (iBOR) as iSD, NON-iCR/NON-iUPD,", - "or NE (should be specified after ibor_isd and ibor_non_icriupd)" + "Define not evaluable (NE) for best overall response (iBOR) as iCR, iPR, iSD,", + "NON-iCR/NON-iUPD, or NE (should be specified after ibor_isd and ibor_non_icriupd)" ), dataset_name = "ovr", - condition = AVALC %in% c("iSD", "NON-iCR/NON-iUPD", "NE"), + condition = AVALC %in% c("iCR", "iPR", "iSD", "NON-iCR/NON-iUPD", "NE"), set_values_to = exprs(AVALC = "NE") )