Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: data source in R/data.R #218

Closed
kaz462 opened this issue Jul 4, 2023 · 9 comments
Closed

Documentation: data source in R/data.R #218

kaz462 opened this issue Jul 4, 2023 · 9 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@kaz462
Copy link

kaz462 commented Jul 4, 2023

Please select a category the issue is focused on?

No response

Let us know where something needs a refresh or put your idea here!

Hi admiralvaccine team, could data source be added to data.R? e.g., data.R from admiralophtha, data.R from admiral.test
Thanks! Link pharmaverse/pharmaversesdtm#4

@ahasoplakus
Copy link
Collaborator

Thanks @kaz462, the data sources have been added to R/data.R. Closing this issue.

@kaz462
Copy link
Author

kaz462 commented Jul 25, 2023

Thanks @ahasoplakus !
For the data sources, could you please list the original sources/programs instead of the URLs in admiralvaccine, e.g., some data are copies from admiral.test, some are reconstructed in programs like the following one from admiralophtha.
(This information is needed for pharmaversesdtm, so that we can recreate the admiralvaccine data there. Thanks again for working on this!)

#' Best Corrected Visual Acuity Analysis Dataset
#'
#' An example Best Corrected Visual Acuity (BCVA) analysis dataset
#' @keywords datasets
#' @family datasets
#' @source
#' Derived from the `oe` and `ADSL` datasets using `{admiral}`, `{admiralophtha}` and
#' (\url{https://github.com/pharmaverse/admiralophtha/blob/main/inst/templates/ad_adbcva.R})
#'
"admiralophtha_adbcva"

@ahasoplakus ahasoplakus reopened this Jul 25, 2023
@ahasoplakus
Copy link
Collaborator

@kaz462 Thank you for the clarification. @arjoon-r @vikrams95 could you please check on your end?

vikrams95 added a commit that referenced this issue Jul 28, 2023
@vikrams95
Copy link
Collaborator

@kaz462 Thanks for bringing up this, we do not have source code for the datasets which we have used except vx_is and vx_suppis. We just mocked the data and used it due to data complexity and time constraint, anyway we will work on adding source code for all the datasets and deploy it on future release. Thanks!!

@kaz462
Copy link
Author

kaz462 commented Jul 28, 2023

@vikrams95 @ahasoplakus Thanks for checking!
cc: @pharmaverse/admiraldata

@manciniedoardo
Copy link

We just mocked the data and used it due to data complexity and time constraint

Hi @vikrams95 @ahasoplakus @neetusan.

In any pharmaverse package, transparency and reproducibility are key - we need to be able to see where data/code comes from, and what we are doing to it. This also ensures that nothing proprietary is accidentally open-sourced. Thus, we cannot just mock up the data, and not include the source program for it or documentation explaining its source. I should also add that the absence of source programs also makes editing your data in the future much harder.

As such, please could you make it a priority to locate your source programs so that we can include them in pharmaversesdtm, or alternatively re-create the source programs entirely. Otherwise we will not be able to include these datasets in pharmaversesdtm.

Thanks!

@ahasoplakus
Copy link
Collaborator

ahasoplakus commented Aug 9, 2023

We just mocked the data and used it due to data complexity and time constraint

Hi @vikrams95 @ahasoplakus @neetusan.

In any pharmaverse package, transparency and reproducibility are key - we need to be able to see where data/code comes from, and what we are doing to it. This also ensures that nothing proprietary is accidentally open-sourced. Thus, we cannot just mock up the data, and not include the source program for it or documentation explaining its source. I should also add that the absence of source programs also makes editing your data in the future much harder.

As such, please could you make it a priority to locate your source programs so that we can include them in pharmaversesdtm, or alternatively re-create the source programs entirely. Otherwise we will not be able to include these datasets in pharmaversesdtm.

Thanks!

Thanks @manciniedoardo we will add the source programs for the remaining data files and update R/data.R accordingly.

arjoon-r added a commit that referenced this issue Aug 22, 2023
Created code for Vaccine DM test data
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
arjoon-r added a commit that referenced this issue Aug 22, 2023
@arjoon-r
Copy link
Collaborator

arjoon-r commented Aug 31, 2023

Hi @kaz462 and @manciniedoardo, The Data sources has been included in R/data.R and also, we have created the source program for each Vaccine specific - SDTM datasets and added them in inst/create_vx_data folder.

@manciniedoardo
Copy link

Thanks @arjoon-r! The plan now would be to move the programs over to {pharmaversesdtm} (our one source for test SDTM data). However we probably will not have time to include this in the first release of {pharmaversesdtm} because that is scheduled for 4th Sept. Additionally, although in our guidance for test data I am seeing that it's not listed as mandatory to use the CDISC pilot DM dataset as a basis (so as to have consistent USUBJIDs etc) all the other test data does do this so it might be worth implementing this in the vaccine programs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants