Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: deprecate/supersede derive_vars_crit() #253

Open
manciniedoardo opened this issue Nov 18, 2024 · 2 comments · May be fixed by #254
Open

Feature Request: deprecate/supersede derive_vars_crit() #253

manciniedoardo opened this issue Nov 18, 2024 · 2 comments · May be fixed by #254
Labels
enhancement New feature or request

Comments

@manciniedoardo
Copy link

manciniedoardo commented Nov 18, 2024 •
edited
Loading

Feature Idea

{admiral} core now has derive_vars_crit_flag(). Consequently derive_vars_crit() in {admiralvaccine} is superfluous now and should be deprecated or superseded according to our deprecation strategy.
@manciniedoardo manciniedoardo added the enhancement New feature or request label Nov 18, 2024
@manciniedoardo
Copy link
Author

@ahasoplakus @pharmaverse/admiralvaccines please could someone take this on?

@bms63
Copy link
Collaborator

bms63 commented Nov 18, 2024

@federicobaratin @MichaelRimler great way for GSK to plug back in!

@manciniedoardo manciniedoardo changed the title Feature Request: deprecate/supercede derive_vars_crit() Feature Request: deprecate/supersede derive_vars_crit() Dec 10, 2024
@federicobaratin federicobaratin linked a pull request Dec 12, 2024 that will close this issue
253 feature request deprecatesupersede derive vars crit #254
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

253 feature request deprecatesupersede derive vars crit pharmaverse/admiralvaccine
2 participants
@bms63 @manciniedoardo