Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hook to allow plugins to download attachments #1018

Open
lwcorp opened this issue Feb 4, 2024 · 0 comments
Open

Add a hook to allow plugins to download attachments #1018

lwcorp opened this issue Feb 4, 2024 · 0 comments

Comments

@lwcorp
Copy link
Contributor

lwcorp commented Feb 4, 2024

viewinbrowser relies on dl.php to download attachments, which requires `&uid=$uid. While this makes perfect sense for e-mail, it cripples the notion of attachments in archives. I mean, there's no sense to see an archive if the whole purpose of the mail was its attachments.

Could you find a way to bypass the protection for certain cases? It could be a special exception for this specific plugin, like changing:
if (isset($_GET['uid']))
and
if (empty($userid))
to
if (...|| (viewinbrowser is used && getConfig('viewbrowser_anonymous')) && getConfig('viewbrowser_anonymous_attachments'))))

Or maybe a more general approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants