Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility - labels aren't clickable #1057

Open
edent opened this issue Oct 29, 2024 · 0 comments · May be fixed by #1058
Open

Accessibility - labels aren't clickable #1057

edent opened this issue Oct 29, 2024 · 0 comments · May be fixed by #1058

Comments

@edent
Copy link

edent commented Oct 29, 2024

The "Search subscribers" page has this searchbox:

image

Clicking on the labels doesn't toggle the checkboxes. The HTML is currently:

<label for="unconfirmed">
   Show only unconfirmed subscribers:
  <input type="checkbox" name="unconfirmed" value="1">
</label>

In order to work, the <input> needs to have an id which matches the label's for. For example:

<input id="unconfirmed">

I'd like to create a PR to fix that in:

$filterpanel .= sprintf('<form method="get" name="listcontrol" action="">
<input type="hidden" name="page" value="users" />
<input type="hidden" name="start" value="%d" />
<input type="hidden" name="find" value="%s" />
<input type="hidden" name="findby" value="%s" />
<label for="unconfirmed">%s:<input onclick="if (this.checked && form.confirmed.checked) form.confirmed.checked=false" type="checkbox" name="unconfirmed" value="1" %s /></label>
<label for="blacklisted">%s:<input onclick="if (this.checked && form.nonblacklisted.checked) form.nonblacklisted.checked=false" type="checkbox" name="blacklisted" value="1" %s /></label>
<div class="clearfix"></div>
<label for="confirmed">%s:<input onclick="if (this.checked && form.unconfirmed.checked) form.unconfirmed.checked=false" type="checkbox" name="confirmed" value="1" %s /></label>
<label for="backlisted">%s:<input onclick="if (this.checked && form.blacklisted.checked) form.blacklisted.checked=false"type="checkbox" name="nonblacklisted" value="1" %s /></label>',

edent added a commit to edent/phplist3 that referenced this issue Oct 29, 2024
@edent edent linked a pull request Oct 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant