Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Social icon for links #563

Open
aagjalpankaj opened this issue Sep 6, 2024 · 7 comments
Open

Feat: Social icon for links #563

aagjalpankaj opened this issue Sep 6, 2024 · 7 comments

Comments

@aagjalpankaj
Copy link
Contributor

aagjalpankaj commented Sep 6, 2024

image

Here is the MR: #601

@aagjalpankaj
Copy link
Contributor Author

aagjalpankaj commented Sep 6, 2024

@nunomaduro If this sounds a good idea I can create an MR for it.

@lewislarsen
Copy link
Contributor

How about pulling the favicon for the website as the icon instead?

A rather cool approach but slightly more complex than choosing from a pre-defined selection.

@JaiveerChavda
Copy link

Interesting idea to implement.

@aagjalpankaj
Copy link
Contributor Author

I quickly prepared #601 with a slightly different approach. Let's see what the maintainers think. Do you have any suggestions on this?

@JaiveerChavda
Copy link

i saw it, looks good.
but what if a user adds their website link.
it's better show a globe or web icon for all website links like this.
image

@fwdmo
Copy link

fwdmo commented Sep 21, 2024

I am already working on this.

chrome_screenshot_Sep 21, 2024 10_50_11 AM GMT+01_00.png

@JaiveerChavda
Copy link

Great!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants