You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
will yield different, incorrect times throughout the day.
As per @pinnymz, ZmanimCalendar should require a date object.
While a datetime object can be coerced to a date, since the caller may possibly want the next day's zmanim (e.g., if it's after nightfall), we agreed that the input should be restricted to date object, placing the onus on the caller to decide which date.
PR to follow.
The text was updated successfully, but these errors were encountered:
This will break backwards compatibility, but every datetime object has a date() method that will return a date, so it shouldn't be too difficult to update old code.
@pinnymz Should we allow datetime objects set to midnight, in an attempt to preserve some backwards compatibility?
Different times yield different zmanim.
MWE:
Even worse, when no date is passed, the default is a
datetime
object with the current time, sowill yield different, incorrect times throughout the day.
As per @pinnymz,
ZmanimCalendar
should require adate
object.While a
datetime
object can be coerced to adate
, since the caller may possibly want the next day's zmanim (e.g., if it's after nightfall), we agreed that the input should be restricted todate
object, placing the onus on the caller to decide which date.PR to follow.
The text was updated successfully, but these errors were encountered: