Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All changes are listed as internal changes #5024

Open
Warashi opened this issue Jul 4, 2024 · 1 comment
Open

All changes are listed as internal changes #5024

Warashi opened this issue Jul 4, 2024 · 1 comment
Assignees
Labels
kind/bug Something isn't working

Comments

@Warashi
Copy link
Contributor

Warashi commented Jul 4, 2024

What happened:

All changes are listed as internal changes.
ref; #5023 (comment)

What you expected to happen:

The PR labels in the config file are listed as not internal changes.

pipecd/RELEASE

Lines 8 to 18 in f71f39c

commitCategories:
- title: "Breaking Changes"
contains:
- change-category/breaking-change
- title: "New Features"
contains:
- change-category/new-feature
- title: "Notable Changes"
contains:
- change-category/notable-change
- title: "Internal Changes"

Currently, we have to include the configured message in the commit body.
But we sometimes want to label the PR after it's merged.

How to reproduce it:

Create release notes with the acitons-gh-release with changes that PR has non-internal changes label.

Environment:

  • piped version:
  • control-plane version:
  • Others:
@Warashi Warashi added the kind/bug Something isn't working label Jul 4, 2024
@t-kikuc t-kikuc self-assigned this Sep 26, 2024
@t-kikuc
Copy link
Member

t-kikuc commented Sep 26, 2024

let me try 🤾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: 🤔 In voting
Development

No branches or pull requests

2 participants