Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling votekicks #6

Open
NotAFile opened this issue Jul 5, 2017 · 3 comments
Open

Handling votekicks #6

NotAFile opened this issue Jul 5, 2017 · 3 comments

Comments

@NotAFile
Copy link
Member

NotAFile commented Jul 5, 2017

It would be great to have some way to show votes client side. This will probably increase participation as well as generally feel better.

It might be an option to make this a text packet.

@feikname
Copy link
Member

feikname commented Jul 5, 2017

This certainly would increase participation, and is a feature I've been longing for ever since AoS started. Totally in favor.

We can use OpenSpades's Client Features Flags to detect whether the client supports GUI votes or not (might be a good idea to implement other kinds of votes together as well). If not, fall back to text mode.

@NotAFile
Copy link
Member Author

NotAFile commented Jul 6, 2017

Yes, the Feature flags are requirements for pretty much all new packets we add...

However, we really must do feature flags on both sides, for other use cases. Adding e.g. #2 would require the Server telling the client it supports additional packets.

That means for me, that the "feature flag" thing really won't scale... we need to add one flag per packet and can add 31 new features before exhausting the flags. Negotiating some kind of "protocol sub-version" might be a better idea and then doing the mapping from that to supported features client and server side.

@noway
Copy link
Member

noway commented Jul 15, 2017

On a more general to this faeture note, I think custom gui boxes is what needed. I.e. the ability to manage UI from server and create special blocks of text such as "2/21\nVoted"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants