Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What to do about Droid Serif? #200

Open
NateWr opened this issue Jan 15, 2021 · 1 comment
Open

What to do about Droid Serif? #200

NateWr opened this issue Jan 15, 2021 · 1 comment

Comments

@NateWr
Copy link
Contributor

NateWr commented Jan 15, 2021

It looks like Google no longer displays Droid Serif font, though requests to it still work. @sssoz identified the issue in this comment.

I'm working to remove the use of Google's CDN in themes, but I'm having trouble locating all of the font files I need for Droid Serif (it doesn't appear in this helper tool).

Should we consider moving away from it? I notice that the HTML galley style uses PT Serif instead. @sssoz how would you feel about moving Droid Serif over to PT Serif for the rest of the theme? Is there a closer match we could use?
@NateWr
Copy link
Contributor Author

NateWr commented Jan 25, 2021

Talked to Sophy and given the time constraints we're going to implement PT Serif. A PR for that is here: #202

edmadrid referenced this issue in cul/ds-ojs Feb 22, 2022
@edmadrid
fix issue with missing font in healthSciences parent theme
612774a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NateWr