Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add queue job unit tests for 3.5 #10306

Open
44 of 51 tasks
touhidurabir opened this issue Aug 13, 2024 · 4 comments
Open
44 of 51 tasks

Add queue job unit tests for 3.5 #10306

touhidurabir opened this issue Aug 13, 2024 · 4 comments
Assignees
@touhidurabir @pkp-dev-infrastructure
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.5 Internal

Comments

@touhidurabir
Copy link
Member

touhidurabir commented Aug 13, 2024 •
edited
Loading

This is a continuation of issue #9899 for 3.5

Job classes to have unit tests

OJS
  • APP\jobs\doi\DepositIssue
  • APP\jobs\notifications\IssuePublishedNotifyUsers
  • APP\jobs\notifications\OpenAccessMailUsers
  • APP\jobs\orcid\DepositOrcidReview
  • APP\jobs\statistics\CompileCounterSubmissionDailyMetrics
  • APP\jobs\statistics\CompileCounterSubmissionInstitutionDailyMetrics
  • APP\jobs\statistics\CompileIssueMetrics
  • APP\jobs\statistics\CompileSubmissionGeoDailyMetrics
  • APP\jobs\statistics\CompileUniqueInvestigations
  • APP\jobs\statistics\CompileUniqueRequests
  • APP\jobs\statistics\CompileUsageStatsFromTemporaryRecords [deprecated 3.4.0.5]
  • APP\jobs\statistics\DeleteUsageStatsTemporaryRecords
  • APP\jobs\statistics\ProcessUsageStatsLogFile
OMP
  • APP\jobs\statistics\CompileCounterSubmissionDailyMetrics
  • APP\jobs\statistics\CompileCounterSubmissionInstitutionDailyMetrics
  • APP\jobs\statistics\CompileSeriesMetrics
  • APP\jobs\statistics\CompileSubmissionGeoDailyMetrics
  • APP\jobs\statistics\CompileUniqueInvestigations
  • APP\jobs\statistics\CompileUniqueRequests
  • APP\jobs\statistics\CompileUsageStatsFromTemporaryRecords [deprecated 3.4.0.5]
  • APP\jobs\statistics\DeleteUsageStatsTemporaryRecords
  • APP\jobs\statistics\ProcessUsageStatsLogFile
OPS
  • APP\jobs\statistics\CompileCounterSubmissionDailyMetrics
  • APP\jobs\statistics\CompileCounterSubmissionInstitutionDailyMetrics
  • APP\jobs\statistics\CompileSubmissionGeoDailyMetrics
  • APP\jobs\statistics\CompileUniqueInvestigations
  • APP\jobs\statistics\CompileUniqueRequests
  • APP\jobs\statistics\CompileUsageStatsFromTemporaryRecords [deprecated 3.4.0.5]
  • APP\jobs\statistics\DeleteUsageStatsTemporaryRecords
  • APP\jobs\statistics\ProcessUsageStatsLogFile
PKP-LIB
  • PKP\jobs\bulk\BulkEmailSender
  • PKP\jobs\doi\DepositContext
  • PKP\jobs\doi\DepositSubmission
  • PKP\jobs\email\EditorialReminder
  • PKP\jobs\invitations\RemoveExpiredInvitationsJob
  • PKP\jobs\metadata\BatchMetadataChangedJob
  • PKP\jobs\metadata\MetadataChangedJob
  • PKP\jobs\notifications\NewAnnouncementNotifyUsers
  • PKP\jobs\notifications\StatisticsReportMail
  • PKP\jobs\notifications\StatisticsReportNotify
  • PKP\jobs\orcid\DepositOrcidSubmission
  • PKP\jobs\orcid\SendAuthorMail
  • PKP\jobs\orcid\RevokeOrcidToken
  • PKP\jobs\statistics\ArchiveUsageStatsLogFile
  • PKP\jobs\statistics\CompileContextMetrics
  • PKP\jobs\statistics\CompileMonthlyMetrics
  • PKP\jobs\statistics\CompileSubmissionMetrics
  • PKP\jobs\statistics\RemoveDoubleClicks
  • PKP\jobs\submissions\RemoveSubmissionFileFromSearchIndexJob
  • PKP\jobs\submissions\RemoveSubmissionFromSearchIndexJob
  • PKP\jobs\submissions\UpdateSubmissionSearchJob

Orcid functionality related tests will be handled by #10127

PRs
pkp-lib --> #10340
ojs --> pkp/ojs#4411
omp --> pkp/omp#1685
ops --> pkp/ops#758
@touhidurabir touhidurabir added this to the 3.5 Internal milestone Aug 13, 2024
@touhidurabir touhidurabir added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Aug 13, 2024
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 27, 2024
@touhidurabir
pkp#10306 unit tests for queue jobs
e199f6f
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 27, 2024
@touhidurabir
pkp/pkp-lib#10306 unit tests for queue jobs
a49bd83
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 27, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
25e3231
This was referenced Aug 27, 2024
Open
Open
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 27, 2024
@touhidurabir
pkp#10306 added unit test for job RemoveExpiredInvitationsJob
33fd288
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 27, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
246006c
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 29, 2024
@touhidurabir
pkp#10306 added not to perform assertion on void return type method
d670e83
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 29, 2024
@touhidurabir
pkp#10306 unit tests for queue jobs
3e1cd67
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 29, 2024
@touhidurabir
pkp#10306 added unit test for job RemoveExpiredInvitationsJob
52a5370
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 29, 2024
@touhidurabir
pkp#10306 added not to perform assertion on void return type method
2fd4f04
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 29, 2024
@touhidurabir
pkp/pkp-lib#10306 added not to perform assertion on void return type …
e3f917e 
…method
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 29, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
9690539
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 29, 2024
@touhidurabir
pkp/pkp-lib#10306 unit tests for queue jobs
a6d4014
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 29, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
005fd09
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 29, 2024
@touhidurabir
pkp/pkp-lib#10306 added not to perform assertion on void return type …
3cb6ad9 
…method
touhidurabir added a commit to touhidurabir/omp that referenced this issue Aug 29, 2024
@touhidurabir
pkp/pkp-lib#10306 unit tests for queue jobs
d6cc982
touhidurabir added a commit to touhidurabir/omp that referenced this issue Aug 29, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
e073111
@touhidurabir touhidurabir mentioned this issue Aug 29, 2024
Open
touhidurabir added a commit to touhidurabir/ops that referenced this issue Aug 30, 2024
@touhidurabir
pkp/pkp-lib#10306 unit tests for queue jobs
8117287
touhidurabir added a commit to touhidurabir/ops that referenced this issue Aug 30, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
8f21975
@touhidurabir touhidurabir mentioned this issue Aug 30, 2024
Open
@touhidurabir
Copy link
Member Author

@asmecher can you take look at the PRs at #10306 (comment) .

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Sep 4, 2024
@touhidurabir
pkp#10306 unit tests for queue jobs
7b04ccb
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Sep 4, 2024
@touhidurabir
pkp#10306 added unit test for job RemoveExpiredInvitationsJob
5306724
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Sep 4, 2024
@touhidurabir
pkp#10306 added not to perform assertion on void return type method
bde3742
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
2151e46
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 added not to perform assertion on void return type …
aed2042 
…method
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 updated tests with support mock
6ea1b64
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 removed direct mocking of job class
bc8fdec
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 fixed namespace issue
526a34f
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 removed unnecessary request param from createNotifi…
464a7db 
…cation method
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 addressed warnings and notification table backup/re…
25a809d 
…store
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 fixed issue with dummy file
430ed94
touhidurabir added a commit to touhidurabir/omp that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
cfe7385
touhidurabir added a commit to touhidurabir/omp that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 unit tests for queue jobs
8da3f82
touhidurabir added a commit to touhidurabir/omp that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
f09d3db
touhidurabir added a commit to touhidurabir/omp that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 fixed issue with dummy file
c769d7e
touhidurabir added a commit to touhidurabir/ops that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
56cfebd
touhidurabir added a commit to touhidurabir/ops that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 unit tests for queue jobs
b149118
touhidurabir added a commit to touhidurabir/ops that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
7367754
touhidurabir added a commit to touhidurabir/ops that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 fixed issue with dummy file
5192bf3
touhidurabir added a commit to touhidurabir/ops that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
7307df9
touhidurabir added a commit to touhidurabir/ops that referenced this issue Nov 14, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
d91602a
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 15, 2024
@touhidurabir
pkp/pkp-lib#10306 unit tests for queue jobs
b6485bb
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 15, 2024
@touhidurabir
pkp/pkp-lib#10306 Submodule Update ##touhidurabir/i10306_main##
134f375
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 15, 2024
@touhidurabir
pkp/pkp-lib#10306 added not to perform assertion on void return type …
605faae 
…method
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 15, 2024
@touhidurabir
pkp/pkp-lib#10306 updated tests with support mock
b102027
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 15, 2024
@touhidurabir
pkp/pkp-lib#10306 removed direct mocking of job class
3a6d53a
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 15, 2024
@touhidurabir
pkp/pkp-lib#10306 fixed namespace issue
2e156cb
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 15, 2024
@touhidurabir
pkp/pkp-lib#10306 removed unnecessary request param from createNotifi…
e99ecac 
…cation method
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 15, 2024
@touhidurabir
pkp/pkp-lib#10306 addressed warnings and notification table backup/re…
aab18f4 
…store
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 15, 2024
@touhidurabir
pkp/pkp-lib#10306 fixed issue with dummy file
6be229d
touhidurabir added a commit to touhidurabir/omp that referenced this issue Nov 15, 2024
@touhidurabir
pkp/pkp-lib#10306 removed deprecated setProxyTarget method usage
02b35b4
touhidurabir added a commit to touhidurabir/omp that referenced this issue Nov 16, 2024
@touhidurabir
pkp/pkp-lib#10306 fixed invalid assoc type for stats log file related…
cdbe4cf 
… job
@touhidurabir
Copy link
Member Author

@asmecher all tests are passing now . If all good, goo to merge , Please take a look at the PRs at #10306 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@touhidurabir touhidurabir

@pkp-dev-infrastructure pkp-dev-infrastructure

Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
3 participants
@asmecher @touhidurabir @pkp-dev-infrastructure