Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Citation Style Language plugin to OMP #6201

Closed
asmecher opened this issue Aug 24, 2020 · 19 comments
Closed

Port Citation Style Language plugin to OMP #6201

asmecher opened this issue Aug 24, 2020 · 19 comments
Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks.
Milestone
3.4.0-0

Comments

@asmecher
Copy link
Member

See https://forum.pkp.sfu.ca/t/how-to-cite-in-open-monograph-press-3-1-0/34493 for details.
@NateWr NateWr added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Aug 25, 2020
@nils-stefan-weiher
Copy link

Yes please! We from Heidelberg University Library may take this up, because we need this to use OMP for the frontend.

@nils-stefan-weiher
Copy link

Dear Alec @asmecher ,

Do you know if someone was working on this, because I found an OMP branch in the plugin repository:
https://github.com/pkp/citationStyleLanguage/tree/omp-stable-3_1_1

We are thinking of porting the plugin for OMP 3.3. But we did not settle yet, if we should use the OJS plugin or use some JavaScript code involving citeproc-js which was used in Dulip's OMP Portal.

Any suggestions?

Thanks and hope you are doing well,

Nils

@asmecher
Copy link
Member Author

asmecher commented Feb 3, 2021

I think this would be a wonderful addition to OMP (and OPS too)! The best approach would be to adapt the existing repository (https://github.com/pkp/citationStyleLanguage) so that it can check which application it's been installed into and adjust its behaviour accordingly. There wouldn't be many changes needed. If you're interested, please go ahead, and I'd be happy to review and support (e.g. adding automated testing)!

@nils-stefan-weiher nils-stefan-weiher mentioned this issue Feb 4, 2021
Closed
1 task
@bolelligallevi
Copy link
Contributor

Hi @isgrim, any update on the plugin porting to OMP?
Best regards,
Stefano

@nils-stefan-weiher
Copy link

Hi @bolelligallevi ,

my colleague (Christian Marsilius, @nongenti )is working on it. I think we have a functional version on our development server. I have to check with him, in what state the code is.

Regards,

Nils

@ronste
Copy link

ronste commented Aug 28, 2021

Hi @isgrim , @nongenti,

may I ask what is the status of porting Citation Style Language plugin to OMP?

Regards,
Ronald

@nongenti
Copy link

Hi @ronste,

we've a solution running with OJS and OMP 3.3. A pull request is still open. I'm also working on a 3.4 version. But first I've to finish chapter landing pages for OMP 3.4, because csl-plugin should also work on chapter landing pages. For now you can have a look at https://github.com/UB-Heidelberg/citationStyleLanguage/tree/stable-3_3_0

Regards,
Christian

@ronste
Copy link

ronste commented Sep 22, 2021

Hi @nongenti ,

thanks for the update. But our installation runs on OMP 3.2. I guess we'll take another route for now.

Regards,
Ronald

@NateWr
Copy link
Contributor

NateWr commented Apr 25, 2022 •
edited
Loading

@nongenti can you confirm if these two PRs are the correct ones to review for this feature? Is there anything else outstanding?

pkp/omp#1035
pkp/citationStyleLanguage#84
pkp/citationStyleLanguage#79 (stable-3_3_0)

@nongenti
Copy link

Hi @NateWr,
there is also version for OJS/OMP 3.3 you reviewed last summer but never merged. pkp/citationStyleLanguage#79
I can't evaluate whether this is important for now or not.

I've to update my 3.4 instance and rework https://github.com/pkp/omp/pull/1035 because the changes regarding DOIs. I think thats done till the end of this week. I let you know.

@NateWr NateWr added Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks. and removed Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. labels May 11, 2022
@NateWr NateWr moved this to Backlog in Metadata and Distribution May 11, 2022
@NateWr NateWr moved this from Backlog to Under Development in Metadata and Distribution May 11, 2022
@asmecher
Copy link
Member Author

Another related PR: pkp/omp#1121

@nongenti, because these PRs span many repositories, it's helpful to make sure they're all listed here in a comment.

@asmecher
Copy link
Member Author

@nongenti, I think there are still a couple of pieces you're working on:

Please make sure to ping me when it's ready for another look and I'll get it merged -- it's very close! Thanks for being patient with us on this one.

@nongenti nongenti mentioned this issue Jan 24, 2023
Closed
@nongenti
Copy link

@asmecher, I think all should be done now.

Overview:
I've closed pkp/omp#1121. We don't need this PR anymore.

In pkp/omp#1245 I add publication and chapter as arguments to hook call CatalogBookHandler::book in OMP CatalogBookHandler.php, like you told me here: pkp/citationStyleLanguage#84 (comment)

pkp/citationStyleLanguage#84 is the CSL-Plugin with namespaces and OMP support.

pkp/ojs#3719 removes only the CSL template code from OJS, like wished here: pkp/omp#1121 (comment)

If you're interested in a CSL-Plugin Version for OMP 3.3 you can also look at this:
pkp/citationStyleLanguage#79

@asmecher
Copy link
Member Author

@nongenti, thanks, that sounds great -- so to summarize, these PRs are what's now relevant, right?

If I have that correct, I've added a new review at pkp/citationStyleLanguage#84 (review) that should cover them.

@nongenti nongenti mentioned this issue Feb 1, 2023
Merged
@asmecher
Copy link
Member Author

asmecher commented Feb 9, 2023

@nongenti, thanks as always for your diligence -- I've merged the OJS and citationStyleLanguage PRs, and just have one outstanding question/comment on the OMP PR:

https://github.com/pkp/omp/pull/1245/files#r1100867573

@asmecher asmecher added this to the 3.4 milestone Feb 9, 2023
@asmecher
Copy link
Member Author

asmecher commented Feb 9, 2023

Note that we're due to release OMP 3.4.0 release candidate 1 (thus starting testing for 3.4.0) in a week -- if you're able to give this a look in the next few days, it'll help us get everything shipped with the release candidate!

@nongenti
Copy link

nongenti commented Feb 9, 2023

@asmecher , changes are implemented. Thanks for your reviews!

asmecher pushed a commit to pkp/omp that referenced this issue Feb 9, 2023
@nongenti
pkp/pkp-lib/issues/6201 Add citationStyleLanguagePlugin support (#1245)
11c1a3c 
* Add publication and chapter to hook: CatalogBookHandler::book

* Rework getBySourceChapterId() in ChapterDAO

* Add availability of hook chapterdao::getLocaleFieldNames

* Add function getChapterBySourceChapterId
@asmecher
Copy link
Member Author

asmecher commented Feb 9, 2023

Hi all -- I've merged this to OMP and added a submodule there. The plugin will be included in OMP 3.4.0. Huge thanks to @nongenti and UB-Heidelberg for their work on this!

@asmecher asmecher closed this as completed Feb 9, 2023
@github-project-automation github-project-automation bot moved this from Under Development to Done in Metadata and Distribution Feb 9, 2023
@danielsf93
Copy link

Hello everyone, I made a plugin that, for now, can solve the problem. https://github.com/danielsf93/ompcitation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks.
Projects
Metadata and Distribution
Status: Done
Milestone
3.4.0-0
Development

No branches or pull requests
7 participants
@asmecher @nils-stefan-weiher @NateWr @bolelligallevi @ronste @nongenti @danielsf93