Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new functions for submission locales conversion into other forms/standards #9838

Open
bozana opened this issue Mar 27, 2024 · 3 comments
Assignees
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone

Comments

@bozana
Copy link
Collaborator

bozana commented Mar 27, 2024

Currently there are functions in LocaleConversion that convert locales from one format into another. This needs to be done also for the new submission and metadata locales that now uses the Weblate language list.
They are for example used in Crossref, DataCite, mEDRA, DOAJ, PubMed, OAI exports.
Search the code for "LocaleConversion::" to see where it is used for submission locales. It could also be that those LocaleConversion functions are not used, for example here https://github.com/pkp/orcidProfile/blob/main/OrcidProfilePlugin.php#L405, so I do not know how should we find all places that needs to be addressed, but... at least to start with LocaleConversion:: and maybe most important plugins...

@bozana bozana added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Mar 27, 2024
@bozana bozana added this to the 3.5 Internal milestone Mar 27, 2024
@bozana
Copy link
Collaborator Author

bozana commented Mar 27, 2024

@ajnyga and @jyhein, would it be possible for you to address this issue? It is 'a left-over' form the #9425 -- I fully forget about this at the end :-) And because you have a better overview how to best convert it, I would love you to do it, if possible. I think you were testing it with the PHP intl functions, no?
Maybe to then either create a new SubmissionLocaleConversion class that will handle this, or to add further function into the existing LocaleConversion...

@ajnyga
Copy link
Collaborator

ajnyga commented Mar 27, 2024

Thanks, yes this is in my followup list. I also hope to at the same time map what kind of multilingual data these services accept. You can assign this to me.

@bozana
Copy link
Collaborator Author

bozana commented Sep 6, 2024

Hi @ajnyga, I am currently working on this issue #9707 -- to align the UI locales with Weblate locales. I will then need to consider these conversion functions for UI locales however, so I think this issue is not needed any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
None yet
Development

No branches or pull requests

2 participants