Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public masthead page #9860

Closed
bozana opened this issue Apr 3, 2024 · 3 comments
Closed

Public masthead page #9860

bozana opened this issue Apr 3, 2024 · 3 comments
Assignees
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone

Comments

@bozana
Copy link
Collaborator

bozana commented Apr 3, 2024

The masthead page should be under context's about.
It should list all active masthead services i.e. all masthead roles as well as uses that are active in those masthead roles and that have accepted to be listed on masthead.
Users are listed with following information: full name, affiliation, start date and orcidIcon (if ORCID authorized).
Reviewer role is treated differently: The reviewers are listed for the previous year. All reviewers that have submitted a review in the previous year will be displayed on the masthead page.

JII plugin should be able to overwrite the masthead users -- generally, a user can opt-out of being displayed on masthead, but this does not guild for JII users -- according to JII all users in the masthead roles needs to be displayed (and cannot opt-out).

PRs:

Upgrade script that adds the Editorial Masthead nav menu item under About nav menu item:
PRs:

@bozana bozana self-assigned this Apr 3, 2024
@bozana bozana added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Apr 3, 2024
@bozana bozana added this to the 3.5.0 LTS milestone Apr 3, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue Apr 3, 2024
bozana added a commit to bozana/ojs that referenced this issue Apr 3, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue Apr 3, 2024
bozana added a commit to bozana/ojs that referenced this issue Apr 3, 2024
@bozana
Copy link
Collaborator Author

bozana commented Apr 3, 2024

@asmecher, could you please review the PRs above?

I see there was about > editorialTeam page that is not used any more, correct? What was this, do you remember? The very old masthead from 2.4?
Can this be removed?
(I will also need to implement a text field for masthead (and journal) history, but that editorialTeam page cannot be used for that, I think, correct?)

EDIT:
The design/HTML is only temporary. When design is finished, we can adapt it.

bozana added a commit to bozana/pkp-lib that referenced this issue Apr 23, 2024
bozana added a commit to bozana/omp that referenced this issue Apr 23, 2024
bozana added a commit to bozana/omp that referenced this issue Apr 23, 2024
bozana added a commit to bozana/ojs that referenced this issue Apr 23, 2024
bozana added a commit to bozana/ojs that referenced this issue Apr 23, 2024
bozana added a commit to bozana/ops that referenced this issue Apr 23, 2024
bozana added a commit to bozana/ops that referenced this issue Apr 23, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue Apr 23, 2024
bozana added a commit to bozana/ops that referenced this issue Apr 23, 2024
bozana added a commit to bozana/omp that referenced this issue Apr 23, 2024
bozana added a commit to bozana/ojs that referenced this issue Apr 23, 2024
This was referenced Apr 25, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue Apr 25, 2024
bozana added a commit to bozana/ojs that referenced this issue Apr 25, 2024
bozana added a commit to bozana/ojs that referenced this issue Apr 25, 2024
bozana added a commit to bozana/ui-library that referenced this issue Apr 25, 2024
bozana added a commit to bozana/ojs that referenced this issue Apr 29, 2024
bozana added a commit that referenced this issue Apr 29, 2024
bozana added a commit to pkp/ojs that referenced this issue Apr 29, 2024
bozana added a commit to pkp/omp that referenced this issue Apr 29, 2024
bozana added a commit to pkp/ops that referenced this issue Apr 29, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue May 2, 2024
bozana added a commit to bozana/ojs that referenced this issue May 2, 2024
@bozana
Copy link
Collaborator Author

bozana commented May 2, 2024

@asmecher, could you please also review these PRs:

@asmecher
Copy link
Member

asmecher commented May 2, 2024

Thanks, @bozana, please go ahead! In general it's not a good idea to use DAOs in the upgrade scripts, because the DAO may change in the future (e.g. as the schema gets adjusted) but the upgrade scripts should not evolve. But we don't have any plans to change this aspect of the code, so I suppose it's OK.

bozana added a commit to bozana/pkp-lib that referenced this issue May 3, 2024
bozana added a commit to bozana/ojs that referenced this issue May 3, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue May 3, 2024
bozana added a commit to bozana/ojs that referenced this issue May 3, 2024
bozana added a commit to bozana/omp that referenced this issue May 3, 2024
bozana added a commit to bozana/ops that referenced this issue May 3, 2024
bozana added a commit that referenced this issue May 3, 2024
#9860 add editorial masthead nav menu item at upgrade
bozana added a commit to pkp/ops that referenced this issue May 3, 2024
pkp/pkp-lib#9860 add editorial masthead nav menu item at upgrade
bozana added a commit to pkp/omp that referenced this issue May 3, 2024
pkp/pkp-lib#9860 add editorial masthead nav menu item at upgrade
bozana added a commit to pkp/ojs that referenced this issue May 3, 2024
pkp/pkp-lib#9860 add editorial masthead nav menu item at upgrade
@bozana bozana closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
Status: Done
Development

No branches or pull requests

2 participants