-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blur results when using exported app html #290
Comments
If these are both compressed models, then the likely culprit is devicePixelRatio. Perhaps @willeastcott can confirm? |
I viewed and log the devicePixelRatio variable in the console and found that in the editor: the value=1.8, while in the app.html, the value=2.0. Could that be the root cause? |
I guess the two windows were on two different screens? This difference is close enough that it shouldn't make a difference. However PlayCanvas can be configured to use devicePixelRatio or not. If not then then rendered image will be lower res (so more blurry). It's possible the editor project is configured to use devicePixelRatio and viewer.html not. |
No, they are displayed on same browser and same screen. Mine is Mac M3. BTW, how to enable devicePixelRatio in viewer.html |
Not sure, but @willeastcott can help (assuming the issue is DPR). |
Try changing <pc-app> to <pc-app high-resolution> in the exported html. Does that help? |
Seemed not changing. Maybe I can send it to you to debug. |
Are you able to provide us the editor project to compare? Thanks! |
Yeah, it'd be useful to have the PLY. |
cropped_mcmc_nov15.debug.compressed.ply.zip |
Ah, I see what's happening:
I'll now submit a PR that updates SuperSplat to the latest version of the Web Components. @slimbuck, are you happy for the viewer to render at physical resolution? Any concerns about performance? |
Performance might suffer so we'll ultimately make it an export option. For now I think it's probably fine though. |
Hi, I've noticed an obvious blurriness when using the exported app html to render my ply. Here're the comparation:
Using Editor:
Using exported HTML:
As I take a deeper look into the code. The compressed ply will drop the SH values to save more bytes. And this is the same with the exported app html. Both the rendering results above were using compressed ply format. So I don't know why there's a big gap between these two formats. Is the app.html rendering pipeline different from that of the editor? Looking forward to your reply.
The text was updated successfully, but these errors were encountered: