-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twitter link should be changed to x links #3994
Comments
This change is fine, but please only update user-facing text and not internal variable names (which make backwards-compatibility more difficult). |
Agreed |
Sure. If there are no issues with the PR, please merge it. I would be happy to contribute to Plone. |
This is definitely not a Plone Improvement Proposal (PLIP). The related PR is a mere one-line internal fix of metadata in @SarthakPaandey please read and follow First-time contributors, especially Things not to do and Item 2 in Work with GitHub issues, Contributing to Plone, and Contribute to Plone 6 core. We cannot even review, much less merge, your pull request until you satisfy contributor requirements. |
@stevepiercy I agree it didn't need to be a PLIP, since it wasn't a controversial change, but you've gone overboard in the other direction. There are other references to Twitter that need to be updated, such as in the social media control panel (https://demo.plone.org/controlpanel/socialmedia) |
@davisagli see #3995. |
I am sorry @stevepiercy. I will follow what you have mentioned. Thanks for the guidance! |
In
setup.py
'sproject_urls
metadata, change Twitter link fromhttps://twitter.com/plone
tohttps://x.com/plone
.The text was updated successfully, but these errors were encountered: