Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter link should be changed to x links #3994

Open
SarthakPaandey opened this issue Aug 5, 2024 · 7 comments · May be fixed by #3995
Open

Twitter link should be changed to x links #3994

SarthakPaandey opened this issue Aug 5, 2024 · 7 comments · May be fixed by #3995

Comments

@SarthakPaandey
Copy link

SarthakPaandey commented Aug 5, 2024

In setup.py's project_urls metadata, change Twitter link from https://twitter.com/plone to https://x.com/plone.

@davisagli
Copy link
Member

This change is fine, but please only update user-facing text and not internal variable names (which make backwards-compatibility more difficult).

@rohnsha0
Copy link
Contributor

rohnsha0 commented Aug 5, 2024

This change is fine, but please only update user-facing text and not internal variable names (which make backwards-compatibility more difficult).

Agreed

@SarthakPaandey
Copy link
Author

SarthakPaandey commented Aug 5, 2024

This change is fine, but please only update user-facing text and not internal variable names (which make backwards-compatibility more difficult).

Sure. If there are no issues with the PR, please merge it. I would be happy to contribute to Plone.

@stevepiercy
Copy link
Contributor

This is definitely not a Plone Improvement Proposal (PLIP). The related PR is a mere one-line internal fix of metadata in setup.py, not anywhere near the scope implied in the issue description. The original description inflated its importance and was very misleading, as other maintainers responded accordingly. @SarthakPaandey doing that is very disrespectful of the Plone community and its volunteers' freely given time and attention. I corrected the description to reflect reality.

@SarthakPaandey please read and follow First-time contributors, especially Things not to do and Item 2 in Work with GitHub issues, Contributing to Plone, and Contribute to Plone 6 core.

We cannot even review, much less merge, your pull request until you satisfy contributor requirements.

@davisagli
Copy link
Member

@stevepiercy I agree it didn't need to be a PLIP, since it wasn't a controversial change, but you've gone overboard in the other direction. There are other references to Twitter that need to be updated, such as in the social media control panel (https://demo.plone.org/controlpanel/socialmedia)

@stevepiercy
Copy link
Contributor

@davisagli see #3995.

@SarthakPaandey
Copy link
Author

I am sorry @stevepiercy. I will follow what you have mentioned. Thanks for the guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants