Illogical behvior when using event_listing on a collection with events.

[ThibautBorn]

description

While working on Issue about the date formatting (plone/Products.CMFPlone#3959), I encountered another issue when using event_listing on collections.

When setting the criteria of a collection, the shown output in the event_listing display often doesn't match the criteria.

Eg. When querying events with end_date before today, I still get only events that will end in the future.
or
When I select ''before today' start_date, the view will only show events that started in the past, but that will end in the future.

The preview, and other views still show the events set by the parameter however.
This is even more confusting, as when selecting the start/end date criteria, the 'toggle' to show past or current events is no longer displayed.

problem: How do we want to implement this behavior?

I made a draft where I was working on this (bcb489b).

• Here I force the listing_view to use the collection's start and end_date criteria when querying the events, the there are start/end criteria specified on the collection.
• I also set the mode to all_events, seen as these are all_events for the parameter.

Is this an better implementation? What does the community think is a sane default? Are there usecases i'm missing that could cause issues?

[ThibautBorn]

additional problem: when viewing a specific event with event_listing, and the event has recurrences both in past and future, we don't see the past events when choosing the past mode. (the future events are shown as expected)