Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing creation/config of SQL tables #196

Open
Zodiac1978 opened this issue Feb 10, 2021 · 2 comments · May be fixed by #251
Open

Optimizing creation/config of SQL tables #196

Zodiac1978 opened this issue Feb 10, 2021 · 2 comments · May be fixed by #251

Comments

@Zodiac1978
Copy link
Member

There is a reported issue with creating the tables in the forums:
https://wordpress.org/support/topic/keine-anziege-von-daten/
Unfortunately the person is not tech savy and switched already to another plugin. No further information besides the (small) hoster name.

And I also have found an issue on a client website:
The table is set to "latin1_german1_ci", which could be the default on the server. I was wondering if we should set this to UTF-8 or not.

@stklcode
Copy link
Contributor

Potentially related to #105 (Database error for MySQL InnoDB database without innodb_large_prefix extension).

And I also have found an issue on a client website:
The table is set to "latin1_german1_ci", which could be the default on the server. I was wondering if we should set this to UTF-8 or not.

We do not provide any specific charset or collate during creation, so we rely on the database default. We should align with WP standards for creation, which is utf8mb4 since 4.2.

We could try to convert the table with an Update, e.g using maybe_convert_table_to_utf8mb4 or custom SQL, if possible.

@2ndkauboy
Copy link
Member

How about adding COLLATE {$wpdb_collate} at table creation? This would not help for existing site, but for new installs.

@jujoko7CF jujoko7CF linked a pull request Mar 19, 2023 that will close this issue
@2ndkauboy 2ndkauboy linked a pull request Mar 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants