Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PhotoInput Component #17

Open
3 tasks
charliepnnl opened this issue May 4, 2023 · 2 comments · May be fixed by #33 or #239
Open
3 tasks

Improve PhotoInput Component #17

charliepnnl opened this issue May 4, 2023 · 2 comments · May be fixed by #33 or #239
Assignees
@jackcruz53
Milestone
Offline Release

Comments

@charliepnnl
Copy link
Contributor

charliepnnl commented May 4, 2023 •
edited
Loading

  • Allow more than one photo to be entered for the same .
    • Establish an attachment naming convention so the multiple photos are associated with the same photo requirement in the database. (The id is the same for all, so we need to append something to the ids.)
    • The photos should be displayed with reduced size so as not to take up too much total space.
    • Allow an optional property maxPhotos with a default of 1.
  • Provide a delete button for each photo.
  • Allow the user to add a note to each photo. This note will appear under the photo in a Photo component.
    • This will require a scheme by which data is stored in the document that is associated with an attachment.
@charliepnnl charliepnnl added this to the BASC Release milestone May 4, 2023
@charliepnnl charliepnnl changed the title Improve PhotoInput Improve PhotoInput Component May 4, 2023
@RaeChen07 RaeChen07 linked a pull request May 9, 2023 that will close this issue
Improvements to the photo input editor #33
Open
@charliepnnl
Copy link
Contributor Author

Let's postpone the "notes" feature to Post BASC Release. I will add a separate issue for that.

@charliepnnl
Copy link
Contributor Author

PhotoInput ideas:

  • Side-by-side if more than one and there is room.
  • Notes TextInput above delete button
    • Cap at 3 or 4 lines
  • Put the Add Photo button at the bottom
  • max prop for maximum number of photos
  • Hide Add Photo button if already max photos

Photo ideas:

  • Hide empty comments
  • Side-by-side if there is room
  • Append 1 of 2 to the right of the Photo title

@jackcruz53 jackcruz53 mentioned this issue Aug 3, 2023
Draft
@sudhacheran sudhacheran linked a pull request Nov 19, 2024 that will close this issue
Photo input – support for multiple photos #239
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackcruz53 jackcruz53

Labels
None yet
Projects
None yet
Milestone
Offline Release
2 participants
@jackcruz53 @charliepnnl