Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing await #272

Open
lautarodragan opened this issue Aug 5, 2019 · 0 comments
Open

Missing await #272

lautarodragan opened this issue Aug 5, 2019 · 0 comments
Labels
bug

Comments

@lautarodragan
Copy link
Member

In this line isValidSignature is missing an await. The promise returned is truthy, always evaluates to true.

poet-js/src/VerifiableClaimSigner.ts

Lines 69 to 70 in f50a701

if (isValidSignature(signedClaim)) return signedClaim
throw new IllegalArgumentException('Claim signature is invalid')

This hasn't been an issue. This code is probably more suitable for a unit test. We could just remove it here and add a unit test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lautarodragan