pop-upgrade breaks third party PPAs

[paulhey]

So this issue is difficult to search for to see if there's a solution.
here's my system:

❯ neofetch
             /////////////                root@########
         /////////////////////            ------------
      ///////*767////////////////         OS: Pop!_OS 21.10 x86_64
    //////7676767676*//////////////       Host: 20EQS57B00 ThinkPad P50
   /////76767//7676767//////////////      Kernel: 5.15.23-76051523-generic
  /////767676///*76767///////////////     Uptime: 53 mins
 ///////767676///76767.///7676*///////    Packages: 2987 (dpkg), 40 (flatpak), 33 (snap)
/////////767676//76767///767676////////   Shell: fish 3.3.1
//////////76767676767////76767/////////   Resolution: 1920x1080, 1920x1080
///////////76767676//////7676//////////   WM: Mutter
////////////,7676,///////767///////////   WM Theme: Adwaita
/////////////*7676///////76////////////   Theme: Adwaita [GTK3]
///////////////7676////////////////////   Icons: Adwaita [GTK3]
 ///////////////7676///767////////////    Terminal: x-terminal-emul
  //////////////////////'////////////     CPU: Intel i7-6700HQ (8) @ 3.500GHz
   //////.7676767676767676767,//////      GPU: Intel HD Graphics 530
    /////767676767676767676767/////       GPU: NVIDIA Quadro M1000M
      ///////////////////////////         Memory: 6605MiB / 31931MiB
         /////////////////////
             /////////////

Whenever I run pop-upgrade it breaks several of the third party repositories I have in my /etc/sources.list.d/ by renaming the distro from focal to impish. Some of these repos only provide packages for LTS distros.
(eg. https://packages.microsoft.com/, https://repo.mongodb.org/apt/ubuntu)

here's the diff on the microsoft one:

❯ git diff microsoft-prod.list
diff --git a/sources.list.d/microsoft-prod.list b/sources.list.d/microsoft-prod.list
index 4af8630..3af6bcb 100644
--- a/sources.list.d/microsoft-prod.list
+++ b/sources.list.d/microsoft-prod.list
@@ -1,5 +1,5 @@
 ## Added/managed by repolib ##
 #
 ## X-Repolib-Name: packages-microsoft-com-ubuntu-20-04-prod
-deb [arch=amd64] https://packages.microsoft.com/ubuntu/20.04/prod focal main
-# deb-src [arch=amd64] https://packages.microsoft.com/ubuntu/20.04/prod focal main
+deb [arch=amd64] https://packages.microsoft.com/ubuntu/20.04/prod impish main
+# deb-src [arch=amd64] https://packages.microsoft.com/ubuntu/20.04/prod impish main

I have temporarily created a git repo for this folder to work around reverting the specific repo files to a known working state (eg. git reset HEAD --hard). Are there any suggestions or recommendations at this point? Should pop-upgrade test the changes to the *.list files after making them? should it leave LTS repos alone? Or is this a repolib issue?

Thanks!

[mmstick]

pop-upgrade does not touch third party sources, besides removing them on upgrade.

[paulhey]

so here's what I'm seeing:

root in apt/sources.list.d on  main
❯ git status
On branch main
nothing to commit, working tree clean

root in apt/sources.list.d on  main
❯ pop-upgrade recovery upgrade from-release
checking if pop-upgrade requires an update
Recovery event: fetching recovery files
Recovery upgrade status: recovery partition refueled and ready to go

root in apt/sources.list.d on  main [!] took 23s
❯ git status
On branch main
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   adoptopenjdk.list
	modified:   byobu-ubuntu-ppa-bionic.list
	modified:   microsoft-prod.list
	modified:   mongodb-org-5.0.list
	modified:   mono-official-stable.list
	modified:   saltstack.list
	modified:   wireshark-dev-ubuntu-stable-focal.list

no changes added to commit (use "git add" and/or "git commit -a")

Is there something else that pop-upgrade calls that might be doing this?

[mmstick]

https://github.com/pop-os/upgrade/blob/master/src/repair/packaging.rs#L18

Sources are fixed to ensure no conflicts with the running release.

[paulhey]

So pop-upgrade modifies the list files directly via the repair function. In the microsoft-prod example above, the "repaired" file is not even correct and causes apt update to error out. Would it not make more sense to at least temporarily disable the third party list files (via repolib, eg. apt-manage modify microsoft-prod --disable) and notify the user that the repo(s) is(/were) disabled? Would it make sense to have a switch for pop-upgrade to prevent it from calling repair?

# EG:
The following third party repos were disabled:
microsoft-prod

If this is unintended, please verify the URL and re-enable with:
`apt-manage modify <repo-name> --enable`

[paulhey]

So when calling pop-upgrade recovery upgrade from-release, it looks like repair gets called here:

upgrade/src/recovery/mod.rs

Line 72 in 0dd0b76

crate::repair::repair().await.map_err(RecoveryError::Repair)?;

[mmstick]

Yes, but you should not use focal repositories on impish.

[paulhey]

That's not helpful. I don't have an alternative as some vendors don't provide packages for non-LTS Ubuntu distros and I don't blame them. I guess I'll have to suffer this process until the next LTS is available and vendors release updated repos to match.

[mmstick]

Look into Flatpak and using Docker for dev containers. Or even nix-env

[paulhey]

Thanks for the suggestions. I use Flatpak where possible, followed by deb packages (and then snaps). In my case, deb package repos are all I have to work with.

[xploz1on]

Look into Flatpak and using Docker for dev containers. Or even nix-env

I had a similar problem. Flatpak if posible for everything if not Docker. RIght now im trying to move everything i can to docker as it makes it super easy to mantain.

DEB packages depends on installed libs. If a DEB depends on an older lib not present on current release you will have the same problem. Just happened to a client trying to install MEGA desktop client on Pop Beta.