-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid broken if no gutter defined #1343
Comments
I have hit this bug too... |
We ran into this issue too. It would be nice if it is fixed going forward. It is definitely a breaking change. |
@datanoise I second that. It'd be absolutely marvellous if the bug got fixed. |
There is a workaround for this with same behaviour. Define the before: after: |
I have already submitted a PR for that.
|
Prefer fetch for default value Co-authored-by: André Jährling <[email protected]>
The following code block in grid.rb will break if no gutter is defined:
the commit be66ddd replaced
options[:row_gutter].to_f
which happily returned0.0
fornil
values withFloat(options[:row_gutter])
which will break withTypeError: can't convert nil into Float
.(I expect the same to happen in other places where
to_f
was replaced withFloat()
)I'd have considered this breaking change that would have merited a mayor version change.
The text was updated successfully, but these errors were encountered: