Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing proper class contructors #28

Open
northern opened this issue Apr 27, 2015 · 0 comments
Open

Missing proper class contructors #28

northern opened this issue Apr 27, 2015 · 0 comments

Comments

@northern
Copy link

I noticed these kind of constructors in the classes:

function NexmoMessage ($api_key, $api_secret) {
    $this->nx_key = $api_key;
    $this->nx_secret = $api_secret;
}

I believe these are PHP4 style constructors and if I'm not mistaken, will be deprecated. It might be good to replace them with proper constructors instead:

http://php.net/manual/en/language.oop5.decon.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant