-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Bid Modules: preventing custom aliases #12135
Labels
Comments
grepped through all the adapters to find any others with a similar issue:
|
andyblackwell
changed the title
bid adapter's preventing custom aliases with their bid validation logic (33across, sharethrough)
bid adapter's preventing custom aliases with their bid validation logic (33across, sharethrough, + others)
Aug 16, 2024
@jefftmahoney fyi |
@andyblackwell feel free to submit pr on anyone affecting you, I'll merge without consulting them However 8.x is closed for additional releases |
This was referenced Aug 17, 2024
1 task
@andyblackwell @patmmccann - PR submitted to address this for Sharethrough's adapter (12136). Let me know if you have any questions or need anything further! |
1 task
8 tasks
This was referenced Aug 21, 2024
patmmccann
changed the title
bid adapter's preventing custom aliases with their bid validation logic (33across, sharethrough, + others)
bid adapter's preventing custom aliases with their bid validation logic
Aug 21, 2024
patmmccann
changed the title
bid adapter's preventing custom aliases with their bid validation logic
Various Bid Modules: preventing custom aliases
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Type of issue
similar to #12047, the bid validation in these bid adapters prevents custom aliasing
Description
bidders don't need to validate the bidder name in isBidRequestValid(), prebid handles that already, and when they do, it prevents being able to use custom aliases, rejecting bids as invalid when a custom alias is used
Steps to reproduce
use a custom alias for the bidders
Expected results
bid requests sent in the auction
Actual results
bids rejected as invalid due to unnecessary bidder name validation
Platform details
all prebid versions that I can tell
Other information
similar issue to #12047
The text was updated successfully, but these errors were encountered: