-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It is possible to specify conflicting info on ad units and ortb2imp #12166
Comments
in general mediaTypes are not valid ortb. We can do this only for specific fields that we decide should be mirrored. Or we could move parts of |
We, Prebid, can keep only one way of defining these params ( a major version change ), preferably through |
Doh, let's scope this down to just battr and these ones https://github.com/prebid/Prebid.js/pull/11970/files#diff-a4386e7142e703699b5a905fc06783725a5eccecb33fa0b1f6b5ab4466fb8286 ? |
outcome: ortb2Imp should win in the case of conflict |
It is possible to do this:
pbjs.requestBids({ adUnits: [{ code: 'test-div', mediaTypes: { banner: { sizes: [[300,250]], battr = [3] } }, ortb2Imp: { banner: { battr = [4] } } }] });
And many publishers specify params for imp.video.* in the mediatype.video object, not the ortb2Imp.video object.
Some adapters look for battr in the latter (ttd), some in the former (pubmatic) and most just use params (we need to clean that up).
Proposal: the ortb2Imp object in the bid request contains the full banner and video objects from the mediatype, and vice versa, but conflicts always resolve to the media type.
This has some impacts on PAAPI bidders, which are reliant on ortb2Imp being detailed
The text was updated successfully, but these errors were encountered: