Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of feature windows when equal stride #59

Open
jvdd opened this issue Mar 28, 2022 · 1 comment
Open

Alignment of feature windows when equal stride #59

jvdd opened this issue Mar 28, 2022 · 1 comment

Comments

@jvdd
Copy link
Member

jvdd commented Mar 28, 2022

There should at least be an option to conveniently align the feature windows when there is an equal stride (or multiples of the minimal stride).

This issue persists when the windows have different length (e.g., "3 min" and "5min") and have an equal stride (e.g., "2min"). The user would want to have the features aligned on the same index (e.g., after 5 min), and not misaligned (as it is right now) after 3min and 5 min.

I guess we could introduce a keyword argument in the FeatureCollection.calculate for this.

Disclaimer: issue was originally highlighted by @emield12

@jvdd
Copy link
Member Author

jvdd commented Jun 7, 2022

PR #62 tackles this (partially) by setting the window_idx="begin" default instead of "end"!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant