Skip to content

Latest commit

 

History

History
105 lines (68 loc) · 3.02 KB

CONTRIBUTING.rst

File metadata and controls

105 lines (68 loc) · 3.02 KB
Raw

Contributing

Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.

You can contribute in many ways:

Types of Contributions

Report Bugs

Report bugs at https://github.com/prestodb/presto-admin/issues.

If you are reporting a bug, please include:

  • Your operating system name and version.
  • Any details about your local setup that might be helpful in troubleshooting.
  • Detailed steps to reproduce the bug.

Fix Bugs

Look through the GitHub issues for bugs. Anything tagged with "bug" is open to whomever wants to implement it.

Implement Features

Look through the GitHub issues for features. Anything tagged with "feature" is open to whomever wants to implement it.

Write Documentation

presto-admin could always use more documentation, whether as part of the official presto-admin docs, in docstrings, or even on the web in blog posts, articles, and such.

Submit Feedback

The best way to send feedback is to file an issue at https://github.com/prestodb/presto-admin/issues.

If you are proposing a feature:

  • Explain in detail how it would work.
  • Keep the scope as narrow as possible, to make it easier to implement.

Get Started!

Ready to contribute? Here's how to set up presto-admin for local development.

  1. Fork the presto-admin repo on GitHub, https://github.com/prestodb/presto-admin.

  2. Clone your fork locally:

    $ git clone [email protected]:your_name_here/presto-admin.git

  3. Install your local copy into a virtualenv. Assuming you have virtualenvwrapper installed, this is how you set up your fork for local development:

    $ mkvirtualenv prestoadmin
$ cd prestoadmin/
$ python setup.py develop

  4. Create a branch for local development:

    $ git checkout -b name-of-your-bugfix-or-feature

    Now you can make your changes locally.

5. When you're done making changes, check that your changes pass flake8 and the tests, including testing other Python versions with tox. To run tests, you need docker installed. You may also need to pip install wheel into your virtualenv. To install and start docker use:

$ wget -qO- https://get.docker.com/ | sh

# Add current user to Docker group to run without sudo
$ sudo gpasswd -a ${USER} docker
$ sudo service docker restart

Now, to run presto-admin tests:

$ make lint
$ make test-all

  1. Commit your changes and push your branch to GitHub:

    $ git add .
$ git commit -m "Your detailed description of your changes."
$ git push origin name-of-your-bugfix-or-feature

  2. Submit a pull request through the GitHub website.

Pull Request Guidelines

Before you submit a pull request, check that it meets these guidelines:

  1. The pull request should include tests.
  2. If the pull request adds functionality, the docs should be updated. Put your new functionality into a function with a docstring, and add the feature to the presto-admin/docs.