Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant ThemeProvider from tests #5301

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Nov 15, 2024

Fixes #4514


For more details, open the Copilot Workspace session.

Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: ea9df69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp self-assigned this Nov 15, 2024
@github-actions github-actions bot added the staff Author is a staff member label Nov 15, 2024
@siddharthkp siddharthkp added fr-skip Remove this from the Design Systems first responder list and removed staff Author is a staff member labels Nov 15, 2024
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 15, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 100.01 KB (0%)
packages/react/dist/browser.umd.js 100.33 KB (0%)

@lesliecdubs
Copy link
Member

Hey @siddharthkp, is it worth trying to hand this over to a Primer teammate or should we close? Would also be helpful to understand the impact of the change: #4514 (comment)

@siddharthkp
Copy link
Member Author

Nah, no need. I'm just exploring how far I can get with copilot workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fr-skip Remove this from the Design Systems first responder list integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests: Remove redundant ThemeProvider from tests
2 participants