Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Autocomplete): Convert Box usage to CSS modules behind feature flag #5451

Merged
merged 23 commits into from
Dec 19, 2024

Conversation

randall-krauskopf
Copy link
Contributor

@randall-krauskopf randall-krauskopf commented Dec 16, 2024

Closes https://github.com/github/primer/issues/4303

Changelog

New

Changed

  • Updated Box usage to use CSS modules behind a feature flag in Autocomplete

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 69042e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 16, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5451 December 16, 2024 23:17 Inactive
Copy link
Contributor

github-actions bot commented Dec 16, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.35 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js 103.71 KB (+0.04% 🔺)

@hussam-i-am hussam-i-am changed the title Auto complete css modules feat(Autocomplete): Convert Box usage to CSS modules behind feature flag Dec 18, 2024
@hussam-i-am hussam-i-am marked this pull request as ready for review December 18, 2024 16:54
@hussam-i-am hussam-i-am requested a review from a team as a code owner December 18, 2024 16:54
@hussam-i-am hussam-i-am added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 59a1346 Dec 19, 2024
45 checks passed
@hussam-i-am hussam-i-am deleted the auto-complete-css-modules branch December 19, 2024 16:25
@primer primer bot mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants