Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify TextField to use different auto-check functionality #3247

Open
acbreton opened this issue Dec 19, 2024 · 2 comments
Open

Modify TextField to use different auto-check functionality #3247

acbreton opened this issue Dec 19, 2024 · 2 comments
Labels
enhancement New feature or request rails

Comments

@acbreton
Copy link

acbreton commented Dec 19, 2024

As mentioned by @camertron in this Slack thread, we're hoping to update the Primer::Alpha::TextField component so that it leverages the auto-check code found in auto-check.ts. There was an issue with trying to read a response object with text() after it had already been consumed in the auto-check utility method.

More info in this Slack thread.

@camertron :

  • Upstream the autocheck.ts code into PVC, which has a lot more mechanisms for announcing, etc than github/auto-check-element does.
  • Modify PVC to automatically attach that js-prevent-default-behavior class, or potentially monkeypatch in dotcom somehow.
@lesliecdubs
Copy link
Member

Hi @acbreton, thanks for the details on this. Are you working within a specific timeline for this change?

@lesliecdubs lesliecdubs added the enhancement New feature or request label Dec 23, 2024
@acbreton
Copy link
Author

acbreton commented Dec 23, 2024

Hey there, I don't believe we are blocked on this as we are using js-prevent-default-behavior as a workaround for now.

Thanks for asking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rails
Projects
None yet
Development

No branches or pull requests

2 participants