Fix Empty Fields Bypass Initial Validation #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sername, password, confirm password fields empty in Signup.html
|
Could you please confirm that, after this changes, user is not able to move ahead with empty fields? Changes are not reflected. |
ashish0kumar
deleted the
fix/empty-fields-bypass-initial-signup-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19
This PR introduces a quick fix for Empty Fields Bypass Initial Validation in signup form by simply adding required attribute in each input field of signup form which will prevent users from clicking "Next" until all required fields are filled in with valid data (not just empty strings).