Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_native_sponge_field_elements cant be called with PrimeField #170

Open
NiDimi opened this issue Oct 16, 2024 · 0 comments · May be fixed by #189
Open

to_native_sponge_field_elements cant be called with PrimeField #170

NiDimi opened this issue Oct 16, 2024 · 0 comments · May be fixed by #189
Assignees
@winderica

Comments

@NiDimi
Copy link
Contributor

NiDimi commented Oct 16, 2024

In the to_sponge_field_elements<F: PrimeField>(&self, dest: &mut Vec<F>) function we cannot call to_native_sponge_field_elements(dest) directly, as to_native_sponge_field_elements needs F to be C::ScalarField, but here F is a generic PrimeField. This affects all the folding schemes that use a CryptographicSponge (Nova, OVA, Hypernova, and the upcoming Mova)
@NiDimi NiDimi mentioned this issue Oct 16, 2024
Merged
@winderica winderica self-assigned this Dec 3, 2024
@winderica winderica linked a pull request Dec 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winderica winderica

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor and simplify the design of traits winderica/sonobe
2 participants
@winderica @NiDimi