Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define IMTNode explicitly instead of any #323

Closed
0xDatapunk opened this issue Sep 11, 2024 · 1 comment
Closed

Define IMTNode explicitly instead of any #323

0xDatapunk opened this issue Sep 11, 2024 · 1 comment
Labels
audit 🔍 This issue is related to an audit. documentation 📖 Improvements or additions to documentation duplicate ‼️ This issue or pull request already exists question ❔ Further information is requested

Comments

@0xDatapunk
Copy link
Collaborator

zk-kit/packages/imt/src/types/index.ts

Line 4 in aa02c6d

export type IMTNode = any

does it make sense to define export type IMTNode = number | string | bigint directly instead of any?
All functions require such types anyway
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ZK-Kit Sep 11, 2024
@cedoor cedoor added documentation 📖 Improvements or additions to documentation audit 🔍 This issue is related to an audit. labels Sep 12, 2024
@cedoor cedoor added question ❔ Further information is requested duplicate ‼️ This issue or pull request already exists labels Oct 16, 2024
@cedoor
Copy link
Member

cedoor commented Oct 16, 2024

Duplicate: #339

@cedoor cedoor closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✔️ Done in ZK-Kit Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit 🔍 This issue is related to an audit. documentation 📖 Improvements or additions to documentation duplicate ‼️ This issue or pull request already exists question ❔ Further information is requested
Projects
ZK-Kit
Status: ✔️ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cedoor @0xDatapunk