Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checking if newLeaf != this._nodes[0][index] first before update #340

Open
0xDatapunk opened this issue Oct 7, 2024 · 0 comments
Open

checking if newLeaf != this._nodes[0][index] first before update #340

0xDatapunk opened this issue Oct 7, 2024 · 0 comments
Labels
audit 🔍 This issue is related to an audit. performance 📈 A code change that improves the performance refactoring ♻️ A code change that neither fixes a bug nor adds a feature

Comments

@0xDatapunk
Copy link
Collaborator

zk-kit/packages/imt/src/imt.ts

Line 227 in c912111

let node = newLeaf

we can save some computation by checking if newLeaf != this._nodes[0][index] first?
@cedoor cedoor added audit 🔍 This issue is related to an audit. refactoring ♻️ A code change that neither fixes a bug nor adds a feature performance 📈 A code change that improves the performance labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit 🔍 This issue is related to an audit. performance 📈 A code change that improves the performance refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
ZK-Kit
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cedoor @0xDatapunk