Replies: 2 comments
-
Added variables description to README. Do you need different prefix for all variables? |
Beta Was this translation helpful? Give feedback.
0 replies
-
I'm fine with my current setup and think amending the documentation should suffice. Thank you. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The used environment variables, mostly prefixed with
POSTGRES_
lead to a collision in my setup. I used your image in OpenShift to back up an instance (a.k.a. deployment) named 'postgres'. OpenShift uses the deployment name to inject environment variables similar to the one already read by the script:POSTGRES_PORT_5432_TCP_ADDR
. This lead to the variablePOSTGRES_PORT
being set totcp://x.x.x.x:5432
by OpenShift as soon as I configured the custom variablePOSTGRES_HOST
. This can be fixed with an additional switch checking the environment variables, but I think the underlying issue is the missing global namespace for custom environment variables. Do you agree or do you like to avoid breaking changes altogether? I won't make an PR with the switch as this is really an edge case, an error in usage even so. Instead the variablePOSTGRES_PORT_5432_TCP_ADDR
should be documented, I think. Effectively the implementation forces OpenShift users having a deployment named 'postgres' to unsetPOSTGRES_HOST
.Beta Was this translation helpful? Give feedback.
All reactions