Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong error about server not supporting MAM. #1940

Closed
mdosch opened this issue Dec 7, 2023 · 2 comments · Fixed by #1941 or #1944
Closed

Wrong error about server not supporting MAM. #1940

mdosch opened this issue Dec 7, 2023 · 2 comments · Fixed by #1941 or #1944
Assignees
@sjaeckel
Labels
bug
Milestone
next

Comments

@mdosch
Copy link
Contributor

mdosch commented Dec 7, 2023

On startup profanity shows the error Server doesn't support MAM (urn:xmpp:mam:2). although the server supports MAM.

Expected Behavior

It should only show that error if the server really doesn't support MAM.

Current Behavior

On startup profanity shows the error Server doesn't support MAM (urn:xmpp:mam:2). although the server supports MAM.

Steps to Reproduce (for bugs)

  1. Start profanity and check messages in console window. (Don't know if this only happens in my set up or in general)

Environment

  • Debian Testing (trixie)
profanity --version
Profanity, version 0.14.0dev.master.0e66cbe4
Copyright (C) 2012 - 2019 James Booth <[email protected]>.
Copyright (C) 2019 - 2023 Michael Vetter <[email protected]>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Disabled
PGP support: Enabled (libgpgme 1.18.0)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Disabled
GTK icons/clipboard: Disabled
GDK Pixbuf: Enabled
@jubalh jubalh added the bug label Dec 7, 2023
@jubalh jubalh added this to the next milestone Dec 7, 2023
@sjaeckel
Copy link
Member

sjaeckel commented Dec 8, 2023 •
edited
Loading

Did you try the patch I shared?
Does it happen for you on first connect as well or only on reconnect?
Going to open a PR with it when I have the time, maybe still today.

@mdosch
Copy link
Contributor Author

mdosch commented Dec 8, 2023 via email

@sjaeckel sjaeckel linked a pull request Dec 9, 2023 that will close this issue
Some fixes #1941
Merged
sjaeckel added a commit that referenced this issue Dec 12, 2023
@sjaeckel
Reset internal flag
629cd33 
Reset the `received_disco_items` flag when initializing the iq module.

This has caused the console error message "Server doesn't support MAM"
sometimes on reconnect.

Fixes #1940

Signed-off-by: Steffen Jaeckel <[email protected]>
H3rnand3zzz pushed a commit to H3rnand3zzz/profanity that referenced this issue Dec 28, 2023
@sjaeckel @H3rnand3zzz
Reset internal flag
ef49a86 
Reset the `received_disco_items` flag when initializing the iq module.

This has caused the console error message "Server doesn't support MAM"
sometimes on reconnect.

Fixes profanity-im#1940

Signed-off-by: Steffen Jaeckel <[email protected]>
sjaeckel added a commit that referenced this issue Dec 28, 2023
@sjaeckel
Fix when feature discovery is finished
8a62d76 
Feature discovery was marked as finished once we received a reply to the
initial request. The discovery mechanism allows to delegate the real
feature discovery to another service running on different domain and those
requests are created dynamically.

This was another instance causing the warning message described in #1940

Fixes #1940 (once more)

Signed-off-by: Steffen Jaeckel <[email protected]>
@sjaeckel sjaeckel mentioned this issue Dec 28, 2023
Merged
1 task
sjaeckel added a commit that referenced this issue Dec 28, 2023
@sjaeckel
Fix when feature discovery is finished
f458d6e 
Feature discovery was marked as finished once we received a reply to the
initial request. The discovery mechanism allows to delegate the real
feature discovery to another service running on different domain and those
requests are created dynamically.

This was another instance causing the warning message described in #1940

Fixes #1940 (once more)

Signed-off-by: Steffen Jaeckel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjaeckel sjaeckel

Labels
bug
Projects
None yet
Milestone
next
Development

Successfully merging a pull request may close this issue.

Some fixes profanity-im/profanity
Fix when feature discovery is finished profanity-im/profanity
3 participants
@sjaeckel @jubalh @mdosch