Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features cannot have cluster codes in just like bitmap feature #1306

Open
brdandu opened this issue Apr 16, 2024 · 1 comment
Open

Features cannot have cluster codes in just like bitmap feature #1306

brdandu opened this issue Apr 16, 2024 · 1 comment
Assignees
Labels
high priority Tag that shows this as higher priority as other issues. matter Important to Matter SDK
Milestone

Comments

@brdandu
Copy link
Collaborator

brdandu commented Apr 16, 2024

We used to have a mechanism where bitmaps could be re-used across clusters for eg:

<bitmap name="Feature" type="bitmap32"> <cluster code="0x040c"/> <cluster code="0x040d" /> <cluster code="0x0413" /> <cluster code="0x0415" /> <cluster code="0x042a" /> <cluster code="0x042b" /> <cluster code="0x042c" /> <cluster code="0x042d" /> <cluster code="0x042e" /> <cluster code="0x042f" /> <field name="Numeric Measurement" mask="0x01" /> <field name="Level Indication" mask="0x02" /> <field name="Medium Level" mask="0x04" /> <field name="Critical Level" mask="0x08" /> <field name="Peak Measurement" mask="0x10" /> <field name="Average Measurement" mask="0x20" /> </bitmap>

Now that the bitmap feature can be replaced by features to avoid redundant xml info as follows:
<features> <feature bit="0" code="MEA" name="NumericMeasurement" summary="Cluster supports numeric measurement of substance"> <optionalConform choice="a" more="true"/> </feature> <feature bit="1" code="LEV" name="LevelIndication" summary="Cluster supports basic level indication for substance using the ConcentrationLevel enum"> <optionalConform choice="a" more="true"/> </feature> <feature bit="2" code="MED" name="MediumLevel" summary="Cluster supports the Medium Concentration Level"> <optionalConform> <feature name="LEV"/> </optionalConform> </feature> <feature bit="3" code="CRI" name="CriticalLevel" summary="Cluster supports the Critical Concentration Level"> <optionalConform> <feature name="LEV"/> </optionalConform> </feature> <feature bit="4" code="PEA" name="PeakMeasurement" summary="Cluster supports peak numeric measurement of substance"> <optionalConform> <feature name="MEA"/> </optionalConform> </feature> <feature bit="5" code="AVG" name="AverageMeasurement" summary="Cluster supports average numeric measurement of substance"> <optionalConform> <feature name="MEA"/> </optionalConform> </feature> </features>

Features does not allow cluster codes to be mentioned within it so it needs to be repeated for each cluster. This ticket requires features to be enabled for multiple clusters just like bitmaps.

@brdandu brdandu added matter Important to Matter SDK high priority Tag that shows this as higher priority as other issues. labels Apr 16, 2024
@brdandu brdandu self-assigned this Apr 16, 2024
@brdandu
Copy link
Collaborator Author

brdandu commented Apr 16, 2024

@kenyhercz kenyhercz added this to the ZAPP-1426 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Tag that shows this as higher priority as other issues. matter Important to Matter SDK
Projects
Development

No branches or pull requests

2 participants