Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of disallowConform in cluster specifications. #1413

Open
bzbarsky-apple opened this issue Aug 27, 2024 · 0 comments
Open
Assignees
Labels
high priority Tag that shows this as higher priority as other issues. matter Important to Matter SDK

Comments

@bzbarsky-apple
Copy link
Contributor

Steps to reproduce:

  1. Add the following to src/app/zap-templates/zcl/data-model/chip/rvc-run-mode-cluster.xml in Matter:
    <features>
      <!-- TODO: ZAP still generates feature bits for things with disallowConform! -->
      <feature bit="0" code="DEPONOFF" name="OnOff" summary="Dependency with the OnOff cluster is disallowed for this cluster">
        <disallowConform/>
      </feature>
      <feature bit="16" code="DIRECTMODECH" name="DirectModeChange" summary="Cluster supports changing run modes from non-Idle states">
        <optionalConform/>
      </feature>
    </features>
    
  2. Remove the Feature bitmap from that cluster.
  3. Rerun codegen.

This generates a feature bit for the OnOff feature, even though it's explicitly listed as not allowed for this cluster.

@brdandu brdandu added matter Important to Matter SDK high priority Tag that shows this as higher priority as other issues. labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Tag that shows this as higher priority as other issues. matter Important to Matter SDK
Projects
Development

No branches or pull requests

2 participants