Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with missing results from JS files #601

Closed
wants to merge 1 commit into from

Conversation

0x123456789
Copy link
Contributor

Hi, fix for #600

@ehsandeep ehsandeep added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Sep 22, 2023
@ehsandeep ehsandeep requested a review from Mzack9999 September 22, 2023 19:24
@0x123456789
Copy link
Contributor Author

@ehsandeep @dogancanbakir @Mzack9999 Hi, are there any update about this?

@Mzack9999
Copy link
Member

@0x123456789 Thanks for opening this PR. Katana was mostly thought as an active crawler (it discover and visit nodes), which is different from a passive crawler (simply discover nodes). This difference becomes important when the maximum depth is reached, since it's that particular phase where nodes can be discovered in the last responses, but are not visited due to maximum depth constraint. The crawler output consists of a request sent/response received, hence probably these endpoints can still be sent in the queue and printed to the output, but we need to add a new attribute to mark that the endpoints are just discovered but not visited, I'll try to implement a generic mechanism for this in your PR.

@Mzack9999
Copy link
Member

Closing as not planned for the time being as not visited results above the depth threshold would be erroneously enqueued for further visiting

@Mzack9999 Mzack9999 closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
3 participants