You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently when applying locales, the fluent-react bindings do not switch the document's text directionality. It's a little odd for React to affect the entire document, but here it seems like it would be the better and less surprising behavior.
I recently converted Firefox's about:profiling page to use Fluent React. However, a follow-up Bug 1688195 was filed as RTL support was not working. I was somewhat surprised that this was the case, as I would have assumed fluent-react to handle this for me.
One way to mitigate surprise for the end user would be to set the RTL direction, by default, and have a config option to opt out of the behavior.
The text was updated successfully, but these errors were encountered:
gregtatum
changed the title
fluent-react bindings should also handle rtl
fluent-react bindings should set the directionality of the page (rtl, ltr)
Jan 25, 2021
But I noticed that other pages using Fluent work properly (both for dir and lang): about:newtab (also about:home), about:config. I believe that about:newtab uses fluent-react too. It's not clear to me how this works there.
I am under the impression that fluent-dom doesn't do it either. In Firefox there is a adhoc mechanism to do it automatically, but that it's not implemented in the generic library.
Currently when applying locales, the fluent-react bindings do not switch the document's text directionality. It's a little odd for React to affect the entire document, but here it seems like it would be the better and less surprising behavior.
I recently converted Firefox's
about:profiling
page to use Fluent React. However, a follow-up Bug 1688195 was filed as RTL support was not working. I was somewhat surprised that this was the case, as I would have assumed fluent-react to handle this for me.One way to mitigate surprise for the end user would be to set the RTL direction, by default, and have a config option to opt out of the behavior.
The text was updated successfully, but these errors were encountered: