Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving over a metadata can cause confusing errors when the newer run has fewer states #135

Open
BaxterEaves opened this issue Oct 6, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@BaxterEaves
Copy link
Contributor

If you do something like

$ lace run --csv small.csv -s 8 -n 1000 metadata.lace
$ lace run --csv big.csv -s 4 -n 1000 metadata.lace

where you save to a metadata directory with a large number of states lace will happily load metadata.lace but when you try to do certain things you'll get strange errors (usually index errors).

FIX

Future versions on the metadata could have a hash for the codebook in the state metadata. This would be a breaking change, so maybe just checking the number of rows, number of columns and feature types in each state during load would suffice for now.

@BaxterEaves BaxterEaves added the bug Something isn't working label Oct 6, 2023
@BaxterEaves BaxterEaves self-assigned this Oct 6, 2023
@BaxterEaves BaxterEaves added this to the v0.5.0 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant