Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is too easy to accidentally rotate a single-sig AID #3

Open
nkongsuwan opened this issue Aug 1, 2024 · 11 comments
Open

It is too easy to accidentally rotate a single-sig AID #3

nkongsuwan opened this issue Aug 1, 2024 · 11 comments

Comments

@nkongsuwan
Copy link
Collaborator

nkongsuwan commented Aug 1, 2024

Is your feature request related to a problem? Please describe.
I feel that it is too easy for users to rotate their single-sig AIDs accidentally. Once published to witnesses, key rotation is permanent and irrevocable. Some users who do not have a deep understanding of KERI may also click the rotation button out of curiosity.

This will be a problem if the rotated AID is a member of a multi-sig AID since that single-sig AID can no longer be used for issuing ACDCs until the multi-sig group AID has also been rotated.

Describe the solution you'd like
There should be an extra step for the users to confirm that they really want to rotate their single-sig AIDs to prevent accidental rotation. The confirmation page/pop-up should also provide a warning that this action is irrevocable.

Additional context
Currently, there is a confirmation popup for multi-sig AID, but not for single-sig AID.
Screenshot 2567-08-01 at 13 31 08

@rodolfomiranda
Copy link

rodolfomiranda commented Aug 3, 2024

Thanks Nuttawut for the feedback, I agree it's important to have a warning before proceeding with the rotation. I'll open an internal ticket with the request.

@Arsh-Sandhu
Copy link
Member

Confirmation popup is already added and is deployed as part of the latest deployment done last week. We can update the text to warn that rotation is irrevocable.

@nkongsuwan
Copy link
Collaborator Author

@Arsh-Sandhu: Perhaps you could add the following message. I made the style similar to the message for multisig rotation

Rotate identifier

Alias
[Alias] [Prefix] [Copy button]

Are you certain you want to rotate the [alias] identifier? This is an irreversible action that will change the key associated with the identifier. Additionally, it may impact any multisig identifier in which this identifier is a participant.

@dhh1128
Copy link
Member

dhh1128 commented Aug 15, 2024

[from twin in jira]
As of 2024-08-15T00:36Z, the status of the issue in jira is 'doing'.

@dhh1128
Copy link
Member

dhh1128 commented Aug 21, 2024

[from twin in jira]
The issue is assigned in jira to Arshdeep Singh.

@dhh1128
Copy link
Member

dhh1128 commented Aug 28, 2024

[from twin in jira]
The issue is assigned in jira to Vlad Radulescu.

@dhh1128
Copy link
Member

dhh1128 commented Aug 28, 2024

[from twin in jira]
As of 2024-08-28T15:14Z, the status of the issue in jira is 'to do'.

@nkongsuwan
Copy link
Collaborator Author

Tell Jira:
// Add a description to the warning message
Rotate identifier

Alias
[Alias] [Prefix] [Copy button]

Are you certain you want to rotate the [alias] identifier? This is an irreversible action that will change the key associated with the identifier. Additionally, it may impact any multisig identifier in which this identifier is a participant.

@dhh1128
Copy link
Member

dhh1128 commented Sep 25, 2024

[from twin in jira]
As of 2024-09-25T15:46Z, the status of the issue in jira is 'in dev'.

@dhh1128
Copy link
Member

dhh1128 commented Oct 8, 2024

[from twin in jira]
As of 2024-10-07T17:39Z, the status of the issue in jira is 'in stage (qa)'.

@dhh1128
Copy link
Member

dhh1128 commented Oct 10, 2024

[from twin in jira]
As of 2024-10-10T10:51Z, the status of the issue in jira is 'done'. Code with the fix has been deployed in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants